Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV changelog updates #7176

Merged
merged 3 commits into from
Jan 7, 2020
Merged

KV changelog updates #7176

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2329607
changelog + pon update
g2vinay Jan 7, 2020
8f3bab3
update changelog
g2vinay Jan 7, 2020
fa020d4
revert external dependency change
g2vinay Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/versioning/external_dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ com.microsoft.azure:spotbugs-maven-plugin;1.2.1
com.microsoft.rest:client-runtime;1.6.15
com.microsoft.rest.v2:client-runtime;2.1.1
com.squareup.okhttp3:okhttp;4.2.2
commons-codec:commons-codec;1.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is failing because you removed an external_dependency that is used by other libraries. In the future, if you're curious as to whether a dependency is being used you can run one of two quick commands to check:

  • From a powershell 6 window, in the root of the enlistment run .\eng\pom_file_version_scanner.ps1 (thought this is only going to tell you after you remove the entry)
  • For something quick and dirty on Windows you can just run findstr /spin /c:"commons-codec:commons-codec" pom*.xml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I already reverted this change

io.micrometer:micrometer-core;1.2.0
io.micrometer:micrometer-registry-azure-monitor;1.2.0
io.micrometer:micrometer-registry-graphite;1.2.0
Expand Down
3 changes: 2 additions & 1 deletion sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Release History

## 4.0.0-beta.8 (Unreleased)
## 4.0.0 (2020-01-07)
- Update azure-core dependency to version 1.2.0.

## 4.0.0-beta.7 (2019-12-17)
- `beginDeleteCertificate` and `beginRecoverDeletedCertificate` methods now return a poll response with a status of SUCCESSFULLY_COMPLETED when service returns 403 status.
Expand Down
4 changes: 3 additions & 1 deletion sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Release History

## 4.1.0-beta.1 (Unreleased)
## 4.1.0 (2020-01-07)
- Fixes the logic of `getKeyId()` method in `KeyEncryptionKeyClient` and `KeyEncryptionKeyAsyncClient` to ensure key id is available in all scenarios.
- Update azure-core dependency to version 1.2.0.

## 4.0.1 (2019-12-06)

Expand Down
4 changes: 3 additions & 1 deletion sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Release History

## 4.1.0-beta.1 (Unreleased)
## 4.1.0 (2020-01-07)
- Update azure-core dependency to version 1.2.0
- Drop commons-codec dependency

## 4.0.1 (2019-12-04)

Expand Down
6 changes: 0 additions & 6 deletions sdk/keyvault/azure-security-keyvault-secrets/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@
<version>1.1.0</version> <!-- {x-version-update;com.azure:azure-core-http-netty;dependency} -->
</dependency>

<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>1.13</version> <!-- {x-version-update;commons-codec:commons-codec;external_dependency} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update the version_client.txt and remove this dependency. I believe this was the only place this dependency was used.

Copy link
Member Author

@g2vinay g2vinay Jan 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming you mean external_dependencies.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track 1 KV still references commons-codec.
So, cannot remove from external_dependencies.txt too,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nothing should ever be deleted from external_dependencies.txt unless you know for an absolute fact it isn't being used by anywhere else. There are several data track libraries that require this dependency. In my comment above I put in a couple of commands that can be run from the command line to check, in the future.

</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down