Enable build failure when code coverage is below threshold #7228
Conversation
srnagar
requested review from
danieljurek,
JimSuplizio,
mitchdenny and
weshaggard
as code owners
srnagar
requested review from
JonathanGiles,
mssfang,
hemanttanwar,
jianghaolu,
samvaity,
alzimmermsft,
anuchandy,
conniey,
sima-zhu and
g2vinay
| @@ -333,6 +333,31 @@ | |||
| <outputDirectory>${project.reporting.outputDirectory}/test-coverage</outputDirectory> | |||
| </configuration> | |||
| </execution> | |||
| <execution> | |||
There was a problem hiding this comment.
@JonathanGiles is this particular change going to require us to up the version and re-release the parent pom?
There was a problem hiding this comment.
@JimSuplizio since this change only introduces a check to fail the build when test coverage is low, it's not end user-facing. So, version update and re-release is not necessary.
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pom.client.xml
Outdated
| <limit> | ||
| <counter>BRANCH</counter> | ||
| <value>COVEREDRATIO</value> | ||
| <minimum>0.09</minimum> |
There was a problem hiding this comment.
Is it worth extracting these two minimum values out to properties so that child poms may overwrite this (in the future when we start setting a valid minimum and libraries need to opt-out for a valid reason)?
There was a problem hiding this comment.
Yes, updated this to use properties and also customized the threshold for a couple of storage modules that had really low coverage to:
- demonstrate how to customize the threshold per module
- increase the base threshold to a much higher number than 9%
srnagar
requested review from
gapra-msft,
jaschrep-msft and
rickle-msft
as code owners
This PR includes two changes:
archetype-sdk-client.ymlwhich were previously configured inclient.yml