Storage ARM Template for live tests #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanttanwar
requested review from
alzimmermsft,
danieljurek,
gapra-msft,
jaschrep-msft,
JimSuplizio,
mitchdenny,
rickle-msft,
sima-zhu and
weshaggard
as code owners
|
/azp run java - storage - tests |
hemanttanwar
requested review from
alzimmermsft
and removed request for
alzimmermsft
alzimmermsft
approved these changes
Jan 9, 2020
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danieljurek
approved these changes
Jan 9, 2020
mikeharder
reviewed
Jan 9, 2020
| PROVISIONER_APPLICATION_ID: $(provisioner-aad-id) | ||
| PROVISIONER_APPLICATION_SECRET: $(provisioner-aad-secret) | ||
| displayName: Remove Test Resources | ||
| condition: true |
There was a problem hiding this comment.
@danieljurek: Should this be condition: always() instead? Or are these equivalent? I assume the intent is to ensure cleanup is always run regardless of earlier failures.
|
Looks like this PR might have broken the Cosmos build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our goal is to create common Azure resources using ARM template for each module. And pipeline to manage common resources and drop them in end. This will save cost and remove unwanted resources after test is complete or stopped in between
Storage will have one common arm template for Queue, File and Blob.
The pipeline will run ARM template and create common resources for example resource group, Accounts etc.
The pipeline will pass on names of these resources as ENV variable into test. For example PRIMARY_STORAGE_ACCOUNT_NAME
In the end pipeline will also delete these common resources which it created earlier and that will cause all the resources created to be removed.