refactoring more duplicated code out of collection classes into GroupableResourcesImpl base class #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2016 18:45
…se class to remove excessive code duplication also, introducing consistent, short, hopefully more intuitive naming: * createFluentModel --> wrapModel * convert --> wrapList also, removing more redundant code
|
Can one of the admins verify this patch? |
added 3 commits
June 17, 2016 21:54
…n, for use in lists of wrappers that aren't groupable resources
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
refactoring more duplicated code out of collection classes into GroupableResourcesImpl base class
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
refactoring more duplicated code out of collection classes into GroupableResourcesImpl base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes renames for better consistency and simplicity:
btw - wrapList is now smart enough to decide on its own whether to convert to PagedList or not, before wrapping in fluent models, so the caller doesn't need to think about that.
This also allows us to remove a lot of redundant/repetitive code and ensure better consistency across impls.