.region() as Region, .regionName() as String; also PIP and AvailabilitySet interface restructuring #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gionName() to return the String this way, .region() will return the more intuitive/discoverable strongly types enum constant, but in case someone cares about handling a future region that's not currently in the constant, they can fall back on .regionName(). With the latter point in mind, this change does NOT change the internal use of region, i.e. I first renamed previously existing .region() to .regionName() and did not change the automatically refactored existing impls to refer to teh new .region(), but kept them as referring to .regionName().
|
Can one of the admins verify this patch? |
added 2 commits
June 25, 2016 09:28
…rganization with more complex models
…th more complex models
martinsawicki
changed the title
|
backing out for now, as Anu raised an interesting question about the organization approach to these interfaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way,
resource.region()will return the more intuitive/discoverable strongly typedRegionenum constant, but in case someone cares about handling a future region that's not currently in the constant, they can fall back on.regionName().With the latter point in mind, this change does NOT change the internal use of region, i.e. I first renamed previously existing
.region()to.regionName()and did not change the automatically refactored existing impls to refer to the new.region(), but kept them as referring to.regionName().