Skip to content

Commit

Permalink
exclude features not for ga (#25977)
Browse files Browse the repository at this point in the history
List of changes for GA SDK:

Autorest.md to point to main stable swagger on api-specs. Wait for this
PR to be finished:
Azure/azure-rest-api-specs#23091
Autorest.md’s tag to be pointing to stable version tag. tag:
package-2023-03-06
Update ServiceVersion in ClientOption: 2023-03-06
Regenerate Autorest with above GA swagger
README.md to be updated to accommodate GA version.
Remove –prerelease tag
Remove any section that presents any feature that should not be included
Changelog.md: Update Release history to be latest version (1.0.0),
Please look at each languages guideline’s section “Package version
number” for details on how each language update this.
Changelog.md: With version updated and new section, add all breaking
changes.

[GA_Release_Checklist.docx](https://microsoft.sharepoint-df.com/:w:/t/ServerCalling/EV3lTIkFsQdJpy7s3J0gutkB0fBxdz-p9Ljtgdur9l8aEQ?e=NNTSK8)
(look at this page for what needs to be included in the changelog)
(Nice to have) Need more samples under Samples forlder.
Features to be excluded:

Remove Custom HMAC support
MediaStreaming features (note this is also included in part of
CreateCall/AnswerCall)
Play,PlaytoAll,Recognize,Cancel are only media feature required – remove
all other media methods
Only Recognize DTMF is to be included in GA. Exclude other Recognize
modes such as Choices, Speech, and continous
Remove all new events that were added with new media features
ChoiceResult
ContinousDTMFRecognition
SendDTMF
All CustomContext related in Signaling methods
All AzureCognitive related features
All mute/unmute features
All play source except FileSource (SSMLSource, TextSource to be
excluded)
Recording’s External Storage related features (such as BlobStorage)
Remove all test associated with removed features
By Removing method and models above, also remove all orphaned
model/enums that are no longer in use (such as, GenderType), Use APIView
to view any orphaned models
  • Loading branch information
ikumarapeli-msft authored May 26, 2023
1 parent 5ae8d9a commit 1f0776a
Show file tree
Hide file tree
Showing 46 changed files with 1,485 additions and 3,287 deletions.
6 changes: 5 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"adfs",
"agrifood",
"AMQP",
"answeredby",
"azsdk",
"Brcpf",
"BRCPF",
Expand Down Expand Up @@ -100,6 +101,7 @@
"Personalizer",
"Petabit",
"Picometer",
"playsourcacheid",
"Plregon",
"PLREGON",
"pnpm",
Expand Down Expand Up @@ -244,7 +246,9 @@
},
{
"filename": "sdk/formrecognizer/ai-form-recognizer/README.md",
"words": ["iddocument"]
"words": [
"iddocument"
]
},
{
"filename": "sdk/formrecognizer/ai-form-recognizer/review/**/*.md",
Expand Down
32 changes: 24 additions & 8 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions sdk/communication/communication-call-automation/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 1.0.0-beta.1 (Unreleased)
## 1.0.0 (2023-05-29)
Call Automation enables developers to build call workflows. Personalise customer interactions by listening to call events and take actions based on your business logic.

### Features Added
Expand All @@ -15,5 +15,3 @@ Call Automation enables developers to build call workflows. Personalise customer
- Record mixed and unmixed audio recordings.
- Download recordings.
- Parse various events happening in the call, such as CallConnected and PlayCompleted event.
- Start/Stop continuous DTMF recognition by subscribing/unsubscribing to tones.
- Send DTMF tones to a participant in the call.
4 changes: 2 additions & 2 deletions sdk/communication/communication-call-automation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const target: CommunicationUserIdentifier = {
}

// make invitation
const callInvite = new CallInvite(target);
const callInvite:CallInvite = {target};

// callback url to recieve callback events
const callbackUrl = "https://<MY-EVENT-HANDLER-URL>/events";
Expand All @@ -65,7 +65,7 @@ const response = callAutomationClient.createCall(callInvite, callbackUrl);
### Play Media
```JavaScript
// from callconnection of response above, play media of media file
const myFile: FileSource = { uri: "https://<FILE-SOURCE>/<SOME-FILE>.wav" }
const myFile: FileSource[] = [{ uri: "https://<FILE-SOURCE>/<SOME-FILE>.wav" }]
const response = callConnection.getCallMedia().playToAll(myFile);
```

Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/communication-call-automation/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@azure/communication-call-automation",
"version": "1.0.0-beta.1",
"version": "1.0.0",
"description": "Azure client library for Azure Communication Call Automation services",
"sdk-type": "client",
"main": "dist/index.js",
Expand Down Expand Up @@ -72,7 +72,7 @@
},
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/communication-common": "^2.2.0",
"@azure/communication-common": "3.0.0-beta.1",
"@azure/core-auth": "^1.3.0",
"@azure/core-client": "^1.3.0",
"@azure/core-paging": "^1.1.1",
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading

0 comments on commit 1f0776a

Please sign in to comment.