[core-xml] fix lint issues (#13701)

Azure · Feb 9, 2021 · a58d064 · a58d064
1 parent 9429159
commit a58d064
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/sdk/core/core-xml/package.json b/sdk/core/core-xml/package.json
@@ -38,8 +38,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint package.json tsconfig.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
-    "lint": "eslint package.json tsconfig.json api-extractor.json src test --ext .ts -f html -o coreXml-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
+    "lint": "eslint package.json api-extractor.json src test --ext .ts",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test:browser && npm run unit-test:browser && npm run integration-test:browser",

diff --git a/sdk/core/core-xml/review/core-xml.api.md b/sdk/core/core-xml/review/core-xml.api.md
@@ -8,7 +8,7 @@
 export function parseXML(str: string, opts?: XmlOptions): Promise<any>;
 
 // @public
-export function stringifyXML(obj: any, opts?: XmlOptions): string;
+export function stringifyXML(obj: unknown, opts?: XmlOptions): string;
 
 // @public
 export const XML_ATTRKEY = "$";

diff --git a/sdk/core/core-xml/src/xml.browser.ts b/sdk/core/core-xml/src/xml.browser.ts
@@ -124,7 +124,7 @@ function domToObject(node: Node, options: Required<XmlOptions>): any {
 
 const serializer = new XMLSerializer();
 
-export function stringifyXML(content: any, opts: XmlOptions = {}): string {
+export function stringifyXML(content: unknown, opts: XmlOptions = {}): string {
   const updatedOptions: Required<XmlOptions> = {
     rootName: opts.rootName ?? "root",
     includeRoot: opts.includeRoot ?? false,

diff --git a/sdk/core/core-xml/src/xml.ts b/sdk/core/core-xml/src/xml.ts
@@ -66,7 +66,7 @@ xml2jsBuilderSettings.renderOpts = {
  * @param opts - Options that govern the XML building of given JSON object
  * `rootName` indicates the name of the root element in the resulting XML
  */
-export function stringifyXML(obj: any, opts: XmlOptions = {}): string {
+export function stringifyXML(obj: unknown, opts: XmlOptions = {}): string {
   xml2jsBuilderSettings.rootName = opts.rootName;
   xml2jsBuilderSettings.charkey = opts.xmlCharKey ?? XML_CHARKEY;
   const builder = new xml2js.Builder(xml2jsBuilderSettings);

diff --git a/sdk/core/core-xml/test/xml.spec.ts b/sdk/core/core-xml/test/xml.spec.ts
@@ -8,7 +8,7 @@ describe("XML serializer", function() {
   describe("parseXML(string)", function() {
     it("with undefined", async function() {
       try {
-        // @ts-expect-error
+        // @ts-expect-error - intentional error for test
         await parseXML(undefined);
         assert.fail("Expected error");
       } catch (error) {
@@ -23,7 +23,7 @@ describe("XML serializer", function() {
 
     it("with null", async function() {
       try {
-        // @ts-expect-error
+        // @ts-expect-error - intentional error for test
         await parseXML(null);
         assert.fail("Expected error");
       } catch (error) {