Skip to content

Commit

Permalink
[Web Pubsub] Renames per arch board (#18399)
Browse files Browse the repository at this point in the history
  • Loading branch information
bterlson authored Oct 28, 2021
1 parent 6cf5309 commit b31eb5d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions sdk/web-pubsub/web-pubsub/review/web-pubsub.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,13 @@ export class WebPubSubServiceClient {
closeAllConnections(options?: HubCloseAllConnectionsOptions): Promise<void>;
closeConnection(connectionId: string, options?: HubCloseConnectionOptions): Promise<void>;
closeUserConnections(userId: string, options?: HubCloseUserConnectionsOptions): Promise<void>;
connectionExists(connectionId: string, options?: HasConnectionOptions): Promise<boolean>;
endpoint: string;
generateClientToken(options?: GenerateClientTokenOptions): Promise<ClientTokenResponse>;
getClientAccessToken(options?: GenerateClientTokenOptions): Promise<ClientTokenResponse>;
grantPermission(connectionId: string, permission: Permission, options?: HubGrantPermissionOptions): Promise<void>;
group(groupName: string): WebPubSubGroup;
hasConnection(connectionId: string, options?: HasConnectionOptions): Promise<boolean>;
hasGroup(groupName: string, options?: HubHasGroupOptions): Promise<boolean>;
groupExists(groupName: string, options?: HubHasGroupOptions): Promise<boolean>;
hasPermission(connectionId: string, permission: Permission, options?: HubHasPermissionOptions): Promise<boolean>;
hasUser(username: string, options?: HubHasUserOptions): Promise<boolean>;
readonly hubName: string;
removeUserFromAllGroups(userId: string, options?: HubCloseConnectionOptions): Promise<void>;
revokePermission(connectionId: string, permission: Permission, options?: HubRevokePermissionOptions): Promise<void>;
Expand All @@ -193,6 +192,7 @@ export class WebPubSubServiceClient {
sendToUser(username: string, message: string, options: HubSendTextToUserOptions): Promise<void>;
sendToUser(username: string, message: JSONTypes, options?: HubSendToUserOptions): Promise<void>;
sendToUser(username: string, message: RequestBodyType, options?: HubSendToUserOptions | HubSendTextToUserOptions): Promise<void>;
userExists(username: string, options?: HubHasUserOptions): Promise<boolean>;
}

// @public
Expand Down
8 changes: 4 additions & 4 deletions sdk/web-pubsub/web-pubsub/src/hubClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ export class WebPubSubServiceClient {
* @param connectionId - Connection id to check
* @param options - Additional options
*/
public async hasConnection(
public async connectionExists(
connectionId: string,
options: HasConnectionOptions = {}
): Promise<boolean> {
Expand Down Expand Up @@ -624,7 +624,7 @@ export class WebPubSubServiceClient {
* @param groupName - The group name to check for
* @param options - Additional options
*/
public async hasGroup(groupName: string, options: HubHasGroupOptions = {}): Promise<boolean> {
public async groupExists(groupName: string, options: HubHasGroupOptions = {}): Promise<boolean> {
const { span, updatedOptions } = createSpan("WebPubSubServiceClient-hub-hasGroup", options);
let response: FullOperationResponse | undefined;
function onResponse(rawResponse: FullOperationResponse, flatResponse: unknown): void {
Expand Down Expand Up @@ -662,7 +662,7 @@ export class WebPubSubServiceClient {
* @param username - The user name to check for
* @param options - Additional options
*/
public async hasUser(username: string, options: HubHasUserOptions = {}): Promise<boolean> {
public async userExists(username: string, options: HubHasUserOptions = {}): Promise<boolean> {
const { span, updatedOptions } = createSpan("WebPubSubServiceClient-hub-hasUser", options);

let response: FullOperationResponse | undefined;
Expand Down Expand Up @@ -806,7 +806,7 @@ export class WebPubSubServiceClient {
*
* @param options - Additional options
*/
public async generateClientToken(
public async getClientAccessToken(
options: GenerateClientTokenOptions = {}
): Promise<ClientTokenResponse> {
const { span, updatedOptions } = createSpan(
Expand Down
6 changes: 3 additions & 3 deletions sdk/web-pubsub/web-pubsub/test/hubs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe("HubClient", function() {
// `removeUserFromAllGroups` always times out.
it.skip("can manage users", async () => {
this.timeout(Infinity);
const res = await client.hasUser("foo");
const res = await client.userExists("foo");
assert.ok(!res);
await client.removeUserFromAllGroups("brian", { onResponse });
assert.equal(lastResponse?.status, 200);
Expand All @@ -147,7 +147,7 @@ describe("HubClient", function() {
it("can check if a connection exists", async function() {
// likely bug in recorder for this test - recording not generating properly
if (!isLiveMode()) this.skip();
const res = await client.hasConnection("xxx");
const res = await client.connectionExists("xxx");
assert.ok(!res);
});

Expand Down Expand Up @@ -177,7 +177,7 @@ describe("HubClient", function() {

// service API doesn't work yet.
it.skip("can generate client tokens", async () => {
await client.generateClientToken({
await client.getClientAccessToken({
userId: "brian"
});
});
Expand Down

0 comments on commit b31eb5d

Please sign in to comment.