-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[core-http] Clean up event listener when streaming is done (#12038)
Currently our cleanup code removes the abort event listener when the response is returned. In streaming case even the response is returned, the work is not done yet, however, with the abort listener removed, we lost the ability to cancel the streaming. This change fixes the issue by unregistering the abort listener for streaming when the stream ends. Now that aborting streaming is working, we are getting AbortError from node-fetch which use a different message "The user aborted a request." than the browser fetch API does. so stop verifying error.message. Port fix to core-https
- Loading branch information
1 parent
8c7ba16
commit f8e023f
Showing
3 changed files
with
55 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters