-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint errors for core packages #10775
Labels
Azure.Core
Client
This issue points to a problem in the data-plane of the library.
help wanted
This issue is tracking work for which community contributions would be welcomed and appreciated
Comments
ghost
added
the
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
label
Aug 23, 2020
ghost
removed
the
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
label
Aug 25, 2020
ramya-rao-a
added
Azure.Core
Client
This issue points to a problem in the data-plane of the library.
labels
Aug 25, 2020
ramya-rao-a
added
help wanted
This issue is tracking work for which community contributions would be welcomed and appreciated
and removed
Up for grabs
labels
Sep 15, 2020
This was referenced Sep 28, 2020
ghost
pushed a commit
that referenced
this issue
Feb 8, 2021
This was referenced Feb 9, 2021
|
ghost
pushed a commit
that referenced
this issue
Feb 17, 2021
Fixes #10775 Brings existing 19 issues down to 0 and makes lint errors fail CI. Notable: I had to pull the websockets test out into separate browser and node.js files. This was because previously, we were using `require` to conditionally pull in the `ws` dependency for node.js, but the linter wants us to stop usage of `require`. There are dynamic `import` statements but not with es6 modules (it requires es2020 I believe). Separating the test by runtime let me use ES2015 imports to import `ws` just in node.js.
Woohoo! Thanks @chradek for taking us over the finish line! |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Azure.Core
Client
This issue points to a problem in the data-plane of the library.
help wanted
This issue is tracking work for which community contributions would be welcomed and appreciated
Fix lint errors found in core packages by ESLint. Following are the steps to run ESLint for core packages and reproduce this issue.
<repo root>/sdk/core/<package-name>
rushx lint
<repo root>/sdk/core/<package-name>
with name ends with lintReport.htmlOnce all known issues are resolved, below change is required in
package.json
file in package root<repo root>/sdk/core/<package-name>
to treat any new lint regression as hard failure in CI.package.json
-f html -o template-lintReport.html || exit 0
Note: HTML report name prefix may be different for each package name to differentiate the report for each package.
The text was updated successfully, but these errors were encountered: