Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core-tracing dependency in core-auth #12612

Closed
ramya-rao-a opened this issue Nov 19, 2020 · 1 comment · Fixed by #13075
Closed

Remove core-tracing dependency in core-auth #12612

ramya-rao-a opened this issue Nov 19, 2020 · 1 comment · Fixed by #13075
Assignees
@chradek
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] January

Comments

@ramya-rao-a
Copy link
Contributor

The @azure/core-auth package was meant to be a light weight one to hold the types and interfaces to be used by anyone trying to implement the credentials used in our latest packages. In #11359, we are discussing using it in our older code generator so that the older packages can make use of @azure/identity as well. Since this package has a dependency on @azure/core-tracing only for types, we now end up pulling un-necessary tracing dependency as well.

This issue is to consider removing the dependency on core-tracing from core-auth and instead duplicate the two types we pull in i.e. SpanOptions and SpanContext

cc @xirzec, @joheredi
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 19, 2020
@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Nov 19, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 19, 2020
@xirzec
Copy link
Member

xirzec commented Nov 19, 2020

I'm good with duplicating.

@ramya-rao-a ramya-rao-a added this to the MQ-2020 milestone Nov 19, 2020
@ramya-rao-a ramya-rao-a assigned chradek and unassigned joheredi Dec 10, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] January Dec 10, 2020
@chradek chradek mentioned this issue Jan 5, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 29, 2021
CodeGen from PR 12612 in Azure/azure-rest-api-specs
91a3ac0 
[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 (Azure#12612)

* Add networkProperties and clusterId

* Add properties: VMGroupName, saskey, fileshare
Change vmSizes to vmsizes, vmSizes_filter to vmsizes_filter to fix S360
issue

* Suppress R4007 DefaultErrorResponseSchema

Co-authored-by: Zhenyu Zhou <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] January
Development

Successfully merging a pull request may close this issue.

[core-auth] remove core-tracing dependency chradek/azure-sdk-for-js
4 participants
@xirzec @ramya-rao-a @joheredi @chradek