Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] - guidance for sharing stateful credentials among various services? #13168

Closed
maorleger opened this issue Jan 12, 2021 · 4 comments
Closed

[Identity] - guidance for sharing stateful credentials among various services? #13168

maorleger opened this issue Jan 12, 2021 · 4 comments
Assignees
@KarishmaGhiya
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@maorleger
Copy link
Member

When a developer wants to integrate with multiple Azure services, how should credentials be used?

For example - let's say I'm integrating with both Blob and EventHub - their constructors take a credential object. Should I instantiate a new credential for each and let caching handle the shared state or should I create a singleton and share it among the various services?

You can see in this sample that I went with the latter but I was wondering should there be guidance around best practices here?

I suspect it matters less for EnvironmentCredentials or other credentials that do not have a lifecycle / state but for something like AuthCodeCredential or InteractiveBrowserCredential should that guidance be documented?
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 12, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 12, 2021
@maorleger maorleger added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 12, 2021
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jan 12, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 12, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] February milestone Jan 12, 2021
@sadasant
Copy link
Contributor

@maorleger I believe that one credential can be shared as many times as needed, as long as the clients support AAD, and as long as the account that gets authenticated has access to the intended resources. Let's ask @schaabs about what he thinks.

@sadasant
Copy link
Contributor

Moved to March.

@sadasant sadasant modified the milestones: [2021] March, [2021] April Feb 10, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
@sumitmal2711 @sumitmal
@mayankagg9722 @vityagi @deymadhumanti @madhude
CodeGen from PR 13168 in Azure/azure-rest-api-specs
5c6c29a 
Users/mayaggar/dataprotection (Azure#13168)

* New Readme Config File

* New Go Language Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New AzureResourceSchema Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Microsoft.data protection (Azure#12814)

* moving changes from Private repo

* changes for autorest vqalidation err

* fix delete response

* fixing lint and model errors

* exposureControlledFeatures fixes

* prettier fixes

* fixing spell check issues

* adding backuptype in custom-words

* PolicyParameters related changes for Disk Backup

* fixing PR comments

* description changes

* changes for preview to stable folder

* changes for retention in monitoring

* changes for stable in readme

* fixing checklist gate issues

* changes for systemdata in dppresource

Co-authored-by: sumitmal <[email protected]>
Co-authored-by: Mayank Aggarwal <[email protected]>
Co-authored-by: vityagi <[email protected]>

* MFA MUA DPP swagger changes (Azure#13081)

* MFA MUA DPP swagger changes

* Resolving PR comments

Co-authored-by: Madhumanti Dey <[email protected]>

* Swagger changes for VaultGuardResource Object (Azure#13116)

* MFA MUA DPP swagger changes

* Resolving PR comments

* MFA MUA dpp swagger changes

* Fixed preetierCheck failures

* Fixed Avocado failures

* Fixed LintDiff warning

* resolved PR comments

* GO SDK fix

* Go SDK fix

* Go SDK fix

* preview related changes

* Go SDK fix

* resolved PR comments

Co-authored-by: Madhumanti Dey <[email protected]>

* changes for preview DPP version

* fix for credscan SAS

Co-authored-by: sumitmal2711 <[email protected]>
Co-authored-by: sumitmal <[email protected]>
Co-authored-by: Mayank Aggarwal <[email protected]>
Co-authored-by: vityagi <[email protected]>
Co-authored-by: deymadhumanti <[email protected]>
Co-authored-by: Madhumanti Dey <[email protected]>
@sadasant sadasant modified the milestones: [2021] April, [2021] May Mar 15, 2021
@sadasant sadasant modified the milestones: [2021] May, [2021] June Apr 2, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July May 12, 2021
@sadasant
Copy link
Contributor

sadasant commented Jun 7, 2021

I think we should revisit this issue next month.

@sadasant sadasant modified the milestones: [2021] July, [2021] August Jun 7, 2021
@sadasant sadasant modified the milestones: [2021] August, Backlog Jul 6, 2021
@sadasant
Copy link
Contributor

sadasant commented Jul 6, 2021

Let’s move this to the backlog so that we can follow up out of schedule.

@sadasant sadasant removed their assignment May 9, 2022
@maorleger maorleger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sadasant @xirzec @maorleger @KarishmaGhiya @ramya-rao-a