Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Update the InteractiveBrowserCredential manual test #13307

Closed
sadasant opened this issue Jan 20, 2021 · 0 comments · Fixed by #13308
Closed

[Identity] Update the InteractiveBrowserCredential manual test #13307

sadasant opened this issue Jan 20, 2021 · 0 comments · Fixed by #13308
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] March

Comments

@sadasant
Copy link
Contributor

sadasant commented Jan 20, 2021 •
edited
Loading

After #13155 the manual test we have for InteractiveBrowserCredential will fail, since MSAL 2.0's authentication flow (from the service side) will explicitly disallow requests that don't happen through CORS.

I have a draft PR here: #13308
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jan 20, 2021
@sadasant sadasant added this to the [2021] February milestone Jan 20, 2021
@sadasant sadasant self-assigned this Jan 20, 2021
sadasant added a commit that referenced this issue Jan 20, 2021
@sadasant
using service-bus for MSAL 2.0
d5faf2a 
Once finished and cleaned up, fixes #13307
@sadasant sadasant mentioned this issue Jan 20, 2021
Merged
sadasant added a commit that referenced this issue Feb 13, 2021
@sadasant @HarshaNalluru
[Identity] Using service-bus for manual test with MSAL 2.0 (#13308)
adf6765 
* using service-bus for MSAL 2.0

Once finished and cleaned up, fixes #13307

* updates after all the testing

* removing preAuthenticate since credential.authenticate is not a thing yet

* Apply suggestions from code review

Co-authored-by: Harsha Nalluru <[email protected]>

* Addressing #13308 (comment)

* Update README.md

* Placeholder for service bus endpoint

* hostname instead of endpoint

* Apply suggestions from code review

Co-authored-by: Harsha Nalluru <[email protected]>

* service bus data owner feedback and package.json version

Co-authored-by: Harsha Nalluru <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] March
Development

Successfully merging a pull request may close this issue.

[Identity] Using service-bus for manual test with MSAL 2.0 Azure/azure-sdk-for-js
1 participant
@sadasant