Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Recorder] Access tokens need to be masked automatically before saving the recordings #15954

Closed
Tracked by #15829
HarshaNalluru opened this issue Jun 24, 2021 · 1 comment
Closed
Tracked by #15829

[Unified Recorder] Access tokens need to be masked automatically before saving the recordings #15954

HarshaNalluru opened this issue Jun 24, 2021 · 1 comment
Labels
test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Jun 24, 2021 •
edited
Loading

This issue is to make sure the access tokens are masked properly in the recordings by the proxy-tool in collab with recorder-new.
@HarshaNalluru HarshaNalluru mentioned this issue Jun 24, 2021
Closed
97 tasks
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 24, 2021
@HarshaNalluru HarshaNalluru reopened this Jun 24, 2021
@HarshaNalluru HarshaNalluru changed the title Access tokens need to be masked automatically before saving the recordings [Recorder] Access tokens need to be masked automatically before saving the recordings Jun 24, 2021
@xirzec xirzec added the test-utils-recorder Label for the issues related to the common recorder label Jun 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 29, 2021
@xirzec xirzec added this to the Backlog milestone Jun 29, 2021
@HarshaNalluru HarshaNalluru changed the title [Recorder] Access tokens need to be masked automatically before saving the recordings [Unified Recorder] Access tokens need to be masked automatically before saving the recordings Jul 26, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Sep 9, 2021
@levimm @charlili1234
@haitch @nilo19 @asilverman @alexeldeib @matthchr
CodeGen from PR 15954 in Azure/azure-rest-api-specs
520ab8f 
Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954)

* Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* add publicNetworkAccess property per network platform's request (Azure#15489)

* add publicNetworkAccess per network platform's request

* fix quota

Co-authored-by: Li Ma <[email protected]>

* update readme for 2021-08-01 sdk generation (Azure#15476)

* update readme for sdk generation

* update readme for sdk generation

Co-authored-by: Charlie Li <[email protected]>

* allow disabling of runcommand (Azure#15481)

* allow disabling of runcommand

* rename file

* another rename

* fix prittier check

* fix stupid prettier check

* change publicNetworkAccess to enum (Azure#15564)

Co-authored-by: Li Ma <[email protected]>

* Add CreationData property to Agentpool level in 2021-08-01 API (Azure#15563)

* Add CreationData property to Agentpool level in 2021-08-01 API

* fix json format

* fix swagger spell check

Co-authored-by: Charlie Li <[email protected]>

* chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (Azure#15579)

* Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (Azure#15586)

* Add CreationData property to Agentpool level in 2021-08-01 API

* Add snapshot related APIs and properties to AKS 2021-08-01 swagger

* fix lint and spell checks

* fix lint and spell checks

* fix PrettierCheck

* Change some Nodepool to NodePool

* some changes according to ARM team's review comments

Co-authored-by: Charlie Li <[email protected]>

* fix tag typo to match tag convention (Azure#15683)

* add workload runtime to agent pool api (Azure#15726)

* add workload runtime to agent pool api

* reference example

* add custom words

* fix: workload runtime description (Azure#15782)

* fix: workload runtime description

* add wasmtime to custom words

* clarify single workload type per node

Co-authored-by: Matthew Christopher <[email protected]>

Co-authored-by: Matthew Christopher <[email protected]>

* fix typo in readme.python.md (Azure#15903)

* Add CreationData property to Agentpool level in 2021-08-01 API

* fix typos in readme.python.md

Co-authored-by: Charlie Li <[email protected]>

* merge recent custom-words.txt changes from main branch to resolve conflicts (Azure#15938)

* Add CreationData property to Agentpool level in 2021-08-01 API

* merge recent custom-words.txt changes from main branch to resolve conflicts

Co-authored-by: Charlie Li <[email protected]>

* pull custom-words.txt from main

* add a new word - NodePool

* add two more words

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Charlie Li <[email protected]>
Co-authored-by: Haitao Chen <[email protected]>
Co-authored-by: Qi Ni <[email protected]>
Co-authored-by: Ariel Silverman <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
@HarshaNalluru
Copy link
Member Author

Not needed for recorder v2, will handle anything remotely related in OAuth sanitizer issue

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xirzec @HarshaNalluru