Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search-documents tests to handle sovereign cloud endpoints dynamically #17577

Closed
benbp opened this issue Sep 10, 2021 · 1 comment
Closed

Update search-documents tests to handle sovereign cloud endpoints dynamically #17577

benbp opened this issue Sep 10, 2021 · 1 comment
Assignees
@sarangan12
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2022] February

Comments

@benbp
Copy link
Member

benbp commented Sep 10, 2021 •
edited
Loading

See related discussion and links for guidance and examples of how to fix this: #17443 (review)

The search-documents tests currently use a switch statement to override endpoint values. This should instead be sourced from dynamic output values in the ARM template.

CC @ramya-rao-a @sarangan12
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 10, 2021
@benbp benbp mentioned this issue Sep 10, 2021
Merged
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Search labels Sep 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 10, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] November milestone Sep 10, 2021
@sarangan12 sarangan12 mentioned this issue Jan 11, 2022
Merged
@sarangan12
Copy link
Member

Code complete with PR #19781

This was referenced Jan 25, 2022
Merged
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 20, 2022
@JackTn @gk-ms
@Khushboo-Baheti @Nilambari @nimaller @pr-work @matyang22 @utbarn-ms @thebenwaters @Satya-anshu @bewaterspassover @bewatersmsft
CodeGen from PR 18440 in Azure/azure-rest-api-specs
68bc986 
Azure Networking 2021-08-01 release of monthly branch (Azure#18440)

* Adds base for updating Microsoft.Network from version stable/2021-05-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Add AppGw swagger changes for L4 proxy (Azure#17561)

* Add AppGw swagger changes for L4 proxy

* Fix Lint Errors

* fix prettier checks

* HubRoutingPreference in VirtualHub (Azure#17609)

* commit1

* commit2

Co-authored-by: Khushboo Baheti <[email protected]>

* MultipleApipa feature VpnSiteLinkConnection and  VirtualNetworkGatewayConnection (Azure#17672)

* VngConnection

* VpnSiteLinkConnection

* fixes

* fixes

* fix2

* fixes

Co-authored-by: Khushboo Baheti <[email protected]>

* Virtual Wan P2S MultiPool feature swagger changes (Azure#17620)

* Virtual Wan P2S MultiPool feature swagger changes

* Fix Swagger LintDiff errors

* Fix LintDiff errors

* Fix errors

* Fix spec

* Fix spec

* Fix spec

* Fix LintDiff errors

* Fix LintDiff errors

* Fix SDK azure-sdk-for-net generation error

* Remove suppression

* Fix errors

* Fix Lintdiff error

* Fix PrettierCheck

* changes (Azure#18002)

* Revert "changes (Azure#18002)" (Azure#18014)

This reverts commit 320ed6a6fc5a68e8af43da303f8e1caaacf24708.

* Add nic auxiliary mode (Azure#17577)

* Add nic auxiliary mode

* fix spacing

* Fixing prettier check

* Restoring package-lock file

* Restoring package json

Co-authored-by: Prachi Bhavsar <[email protected]>

* Connection Draining add new properties (Azure#18052)

* merge

* fix

* fix

* Adding express route port authorization apis (Azure#17582)

* adding apis and updating resource to support ports auth

* moving change to 2021-08-01

* minor: removing change from 2020-07-01

* lintdiff : adding type object

* minor: fixing prettier

* adding authorizations to ports property

* fixing circuitResourceUri property name

* fixing model validation

* changing circuit resource uri type to string

* removing authorizations child reosurce from parent property

* Fix Azure Firewall Policy regressions. Back fix validation issues (Azure#18233)

* Fix regressions in Firewall Policy Swagger / give firewallPolicy.json some love

* Additional lint violations

* remove breaking changes for next time. TO DO

* Revert "remove breaking changes for next time. TO DO"

This reverts commit 8f44a174c73c02d18d829f6dfb1d990488770b23.

* Reintroduce api-version for idps signature based routes. Create better names for enums to be generated in SDKs

* standardize enum names with FirewallPolicy prefix

* Azure Firewall Support of Private IP Ranges in IDPS (Azure#18320)

* Azure Firewall Support of Private IP Ranges in IDPS

* make sure all arrays have x-ms-identifiers

* FirewallPolicy not Firewall policy

fix spellcheck validation

* Ability to update tags on firewall policies (Azure#18322)

* Support updating of Azure Firewall Policy Tags. Includes HTTP Patch example

* Use common-types ErrorDetail

* Ability to update tags for Firewall Policies

* spell check fix for firewallpolicy

* Use future release api-version for example

* Added flush conn to nsg (Azure#18393)

* Added flush conn to nsg

* Updated flushConn to correct location

* Updated description

* Modified T/F to Enabled/Disabled

* Refactoring so that null value appears first

* Reverted FlushConnection to boolean value instead of string

* Revert "Added flush conn to nsg (Azure#18393)" (Azure#18576)

This reverts commit 6541d305880d1cf580496adc01f55197a01e992c.

* Fixing typo in response of idps private ip range feature (Azure#18574)

* Use common-type api version (Azure#18729)

Co-authored-by: Ben Eshed <[email protected]>

* fix (Azure#18417)

Co-authored-by: Tianen <[email protected]>
Co-authored-by: gk-ms <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Nilambari <[email protected]>
Co-authored-by: nimaller <[email protected]>
Co-authored-by: pracsb <[email protected]>
Co-authored-by: Prachi Bhavsar <[email protected]>
Co-authored-by: Matthew Yang <[email protected]>
Co-authored-by: utbarn-ms <[email protected]>
Co-authored-by: Ben Eshed <[email protected]>
Co-authored-by: Satya-anshu <[email protected]>
Co-authored-by: bewaterspassover <[email protected]>
Co-authored-by: Ben Eshed <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarangan12 sarangan12

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2022] February
Development

No branches or pull requests
3 participants
@sarangan12 @benbp @ramya-rao-a