Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-rest-pipeline] HttpHeaders raw header names are lost #18367

Closed
jeremymeng opened this issue Oct 26, 2021 · 0 comments · Fixed by #18517
Closed

[core-rest-pipeline] HttpHeaders raw header names are lost #18367

jeremymeng opened this issue Oct 26, 2021 · 0 comments · Fixed by #18517
Assignees
@xirzec
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@jeremymeng
Copy link
Member

We don't store the raw header names. rawHeaders() only returns the lowercase header keys and values.

in core-http the original header names are stored in _headersMap values, and returned when calling headersArray()
@jeremymeng jeremymeng added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Oct 26, 2021
xirzec added a commit to xirzec/azure-sdk-for-js that referenced this issue Nov 3, 2021
@xirzec
[core-rest-pipeline] Preserve header casing
ae9fd9d 
Preserve original casing of HTTP header names when converting HttpHeader collections back to JSON and when iterating over stored name/value pairs.

Fixes Azure#18367
@xirzec xirzec mentioned this issue Nov 3, 2021
Merged
xirzec added a commit that referenced this issue Nov 10, 2021
@xirzec
[core-rest-pipeline] Preserve header casing (#18517)
638d5eb 
Preserve original casing of HTTP header names when iterating over stored name/value pairs and optionally when converting HttpHeader collections back to JSON.

Fixes #18367
danieljurek pushed a commit that referenced this issue Nov 10, 2021
@xirzec @danieljurek
[core-rest-pipeline] Preserve header casing (#18517)
6e598ec 
Preserve original casing of HTTP header names when iterating over stored name/value pairs and optionally when converting HttpHeader collections back to JSON.

Fixes #18367
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xirzec xirzec

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core-rest-pipeline] Preserve header casing xirzec/azure-sdk-for-js
2 participants
@xirzec @jeremymeng