Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package puppeteer has a new version available #19234

Closed
azure-sdk opened this issue Dec 10, 2021 · 0 comments · Fixed by #20782
Closed

Dependency package puppeteer has a new version available #19234

azure-sdk opened this issue Dec 10, 2021 · 0 comments · Fixed by #20782
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required Deprecated-Dependency
Milestone
[2022] April

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2021 •
edited
Loading

We have identified a dependency on version 10.4.0 of puppeteer. Version 10.4.0 of puppeteer has been deprecated.
A new version (13.5.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Dec 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2021
@azure-sdk azure-sdk added Deprecated-Dependency and removed EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Feb 7, 2022
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Mar 9, 2022
@jeremymeng jeremymeng added this to the [2022] April milestone Mar 9, 2022
@maorleger maorleger mentioned this issue Mar 11, 2022
Merged
3 tasks
maorleger added a commit that referenced this issue Mar 11, 2022
@maorleger
[engSys] - Upgrade puppeteer (#20782)
8d5a1b2 
### Issues associated with this PR
Resolves #19234 

### Describe the problem that is addressed by this PR
Upgrades puppeteer to the latest version

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
I looked through the changelog for puppeteer and did not see any major changes between 10 and 13 that should impact us
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@maorleger @WeiJun428
[engSys] - Upgrade puppeteer (Azure#20782)
a12e45a 
### Issues associated with this PR
Resolves Azure#19234 

### Describe the problem that is addressed by this PR
Upgrades puppeteer to the latest version

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
I looked through the changelog for puppeteer and did not see any major changes between 10 and 13 that should impact us
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@maorleger @WeiJun428
[engSys] - Upgrade puppeteer (Azure#20782)
f529a30 
### Issues associated with this PR
Resolves Azure#19234 

### Describe the problem that is addressed by this PR
Upgrades puppeteer to the latest version

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
I looked through the changelog for puppeteer and did not see any major changes between 10 and 13 that should impact us
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Oct 14, 2022
@Hardell @seandkim
@markcowl @annaji-msft @tomkerkhove @DeagleGross @LFZ96 @Mielek @malincrist @GuanchenIntern @VatsaPatel @agapovm
CodeGen from PR 20399 in Azure/azure-rest-api-specs
341a6b2 
[2022-04-01-preview] Add New Api-version for Microsoft.ApiManagement (Azure#20399)

* Adds base for updating Microsoft.ApiManagement from version preview/2021-12-01-preview to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* APIM Auth Servers (Azure#19234)

* APIM Auth Servers

* adding x-ms-identifiers

* removing some weird, invisible special char

* formatting

* oAuth2AuthenticationSettings moved to AuthSettings

* Formatting

Co-authored-by: Milan Zolota <[email protected]>

* API Management Authorization Endpoints (Azure#19615)

* Add blockchain to latest profile

* Add additional types

* add authorizations definitions

* authorizations operations

* add examples

* update readme

* fix examples

* fix linter delete errors

* address CI validation errors

* prettier fix

* update to 2022-04

* fix readme

* Update specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimauthorizationproviders.json

Co-authored-by: Sean Kim <[email protected]>

* update versions

* Apply suggestions from code review

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Annaji Sharma Ganti <[email protected]>
Co-authored-by: Annaji Sharma Ganti <[email protected]>

* Move Long running Create Operation from Location based to Azure-AsyncOperation Header (Azure#19733)

* azure-asyncOperation

* prettier

* fix(apim): Add missing 'metrics' property to diagnostics contract in 2022-04-01-preview (Azure#20317)

* apim /PUT apis import add translateRequiredQueryParameters (Azure#20333)

* [2022-04-01-preview] Replace resource with proxyresource and TrackedResource (Azure#20461)

* replace resource with proxyresource

* revert to proxyresource

* Add type object to authorization definitions (Azure#20631)

Authorization definitions were missing "type": "object", and this change adds that key/value pair

* Add type object to policy fragment definition (Azure#20585)

* APIM Open ID Connect providers (Azure#20622)

* APIM Open ID Connect providers

* added new proeprties for update

* prettier

* [APIM] Add Nat Gateway (Azure#19990)

* Update apimdeployment.json

* Create ApiManagementCreateServiceWithNatGatewayEnabled.json

* fix typo in file

* Change Nat Gateway property to enum

* modify type of natgateway state

* update property name

* add example reference

* small fix in example

* rename to  outboundPublicIPAddresses

Co-authored-by: Samir Solanki <[email protected]>

* [2022-04-01-preview] MIgrate2Stv2 API (Azure#20504)

* migrate2stv2

* updated to post

* 202 and location

* add body to 202

* remove body from 202

Co-authored-by: Vatsa Patel <[email protected]>
Co-authored-by: Samir Solanki <[email protected]>
Co-authored-by: [email protected] <[email protected]>

* Address Authorizations MissingTypeObject errors (Azure#20919)

* Add forgotten If-Match header (Azure#20920)

* Add forgotten If-Match header

`If-Match` header for the `DeleteAuthorizationAccessPolicy.json file` was forgotten. This change adds the wildcard character for the `If-Match` header for that file.

* Update ApiManagementDeleteAuthorization.json

* Use common types for specs and count as readonly (Azure#21023)

* common types

* count readonly

* Sasolank/more review comments (Azure#21025)

* XML

* proxy to gateway

* Update Authorizations Spec (Azure#21027)

* Update definitions.json

Update wording for PostGetLoginLink endpoint description

* Update apimauthorizationproviders.json

Add 201 response to all Authorization PUT requests

* Updated examples and fixed formatting

There was a formatting issue within apimauthorizationproviders.json, and the Authorization examples needed to be updated with the new 201 responses for creating/updating Authorization entities.

* Add long-running-operation key/value

Added x-ms-long-running-operation: true to Authorization PUT requests

* Remove long-running-operations

* readonly revert (Azure#21050)

* Set  SchemaContract.Document as required. (Azure#20110)

* Updated documentation of the SchemaContract. Server use to return code 500 in case SchemaContract.Document is null. That issue was fixed in the APIM and server will return proper response code.

* Fix AzureApiValidation

* update field with properties

* revert remaining readonly on collection (Azure#21051)

* Change to camel casing for "accesspolicies" (Azure#21070)

* Change to camel casing for "accesspolicies"

* More camel casing updates for access policies

* list example fixed (Azure#21089)

* fix definition (Azure#21110)

* upgrade to v3 for common types (Azure#21109)

* upgrade to v3

* Space

* revert to v2 proxyResource

Co-authored-by: Milan Zolota <[email protected]>
Co-authored-by: Milan Zolota <[email protected]>
Co-authored-by: Sean D Kim <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Annaji Sharma Ganti <[email protected]>
Co-authored-by: Annaji Sharma Ganti <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Korolev Dmitry <[email protected]>
Co-authored-by: Logan Zipkes <[email protected]>
Co-authored-by: Rafał Mielowski <[email protected]>
Co-authored-by: malincrist <[email protected]>
Co-authored-by: GuanchenIntern <[email protected]>
Co-authored-by: VatsaPatel <[email protected]>
Co-authored-by: Vatsa Patel <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Maxim Agapov <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required Deprecated-Dependency
Projects
None yet
Milestone
[2022] April
Development

Successfully merging a pull request may close this issue.

[engSys] - Upgrade puppeteer maorleger/azure-sdk-for-js
3 participants
@maorleger @jeremymeng @azure-sdk