Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified recorder] Redirected requests not being sent to test proxy #21219

Closed
timovv opened this issue Apr 5, 2022 · 1 comment · Fixed by #21355
Closed

[Unified recorder] Redirected requests not being sent to test proxy #21219

timovv opened this issue Apr 5, 2022 · 1 comment · Fixed by #21355
Assignees
@timovv
Labels
test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] May

Comments

@timovv
Copy link
Member

timovv commented Apr 5, 2022

Related:

When using the redirectless test proxy image (tag 1.0.0-dev.20220401.2), redirected requests are not sent to the test proxy and instead go to the live service directly. This is an issue in record mode, as these requests don't get recorded, and also in playback mode, when the live service may not exist and probably won't accept the redirected request.

Cc: @HarshaNalluru @scbedd
@timovv timovv added the test-utils-recorder Label for the issues related to the common recorder label Apr 5, 2022
@timovv timovv added this to the [2022] May milestone Apr 5, 2022
@timovv timovv self-assigned this Apr 5, 2022
@timovv
Copy link
Member Author

timovv commented Apr 6, 2022 •
edited
Loading

Some findings:

  • It's unlikely we can get around this in browser. XHR will always follow redirects and there's no option to disable. fetch has a "manual" mode, but it doesn't really do what we want.
  • In Node, redirects definitely aren't being sent to the test proxy when using core-rest-pipeline. Still need to test out the core-http case.

timovv added a commit to timovv/azure-sdk-for-js that referenced this issue Apr 11, 2022
@timovv
Ensure redirected requests are passed to the recorder in Node
a4a98ad 
Fixes Azure#21219
@timovv timovv mentioned this issue Apr 12, 2022
Merged
@timovv timovv mentioned this issue May 2, 2022
Closed
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Oct 21, 2022
CodeGen from PR 21219 in Azure/azure-rest-api-specs
e65b742 
[Go] update readme.go.md (Azure#21219)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timovv timovv

Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] May
Development

Successfully merging a pull request may close this issue.

[Recorder] Ensure redirected requests are passed to the recorder in Node timovv/azure-sdk-for-js
1 participant
@timovv