Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app-config] Separation of internal and public tests into separate folders for min-max testing #9452

Closed
1 task
KarishmaGhiya opened this issue Jun 10, 2020 · 0 comments · Fixed by #12694
Closed
1 task

[app-config] Separation of internal and public tests into separate folders for min-max testing #9452

KarishmaGhiya opened this issue Jun 10, 2020 · 0 comments · Fixed by #12694
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Milestone
MQ-2020

Comments

@KarishmaGhiya
Copy link
Member

Packages -

  • "@azure/app-configuration"

  • Min-max dependency testing needs to be enabled on all packages and it works on public APIs.

  • The test/public folder should contain usage of ONLY the public exported APIs

  • Careful and manual code separaton of these tests need to be done

  • Example of folder separation done on keyvault-secrets - https://github.com/Azure/azure-sdk-for-js/pull/9211/files
@KarishmaGhiya KarishmaGhiya added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Jun 10, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 10, 2020
@KarishmaGhiya KarishmaGhiya linked a pull request Nov 25, 2020 that will close this issue
[App Config] Separate app config tests into public and internal to enable min-max tests #12694
Merged
@KarishmaGhiya KarishmaGhiya modified the milestones: Backlog, MQ-2020 Nov 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
MQ-2020
2 participants
@KarishmaGhiya @ramya-rao-a