[App Config] Separate app config tests into public and internal to enable min-max tests #12694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KarishmaGhiya
commented
Nov 25, 2020
•
KarishmaGhiya
commented
- Segregation of tests into public and internal
- Enable min-max tests
- Ensure the number of tests run in min-max = no of tests in the public folder
KarishmaGhiya
requested review from
chradek,
danieljurek and
richardpark-msft
as code owners
ghost
added
the
chradek
reviewed
Nov 25, 2020
sdk/appconfiguration/app-configuration/test/internal/http.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/internal/http.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/utils/testHelpers.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/policies/throttlingRetryPolicyTests.spec.ts
Show resolved
Hide resolved
chradek
approved these changes
Nov 25, 2020
This was referenced Feb 16, 2021
[Eventgrid] Separation of internal and public tests into separate folders for min-max testing
#13813
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.