Regenerate Cognitive Services Anomaly Detector SDK #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the issue: https://github.com/Azure/sdk-release-request/issues/573
Version change
There are no breaking changes except one line.
granularityis setnullable:falsein this change. It did not have that property previously.But, even without this
nullableproperty set to false, in the previous code, we cannot send in a Request with no granularity or null/undefined granularity. The service will throw an error with the messagegranularityis required. I have validated this with the previous SDK.There is a possibility that if the service is updated now for throwing the error. But, I doubt that is the case. The Azure portal still mentions this as Preview. The GA release is only on 9/21.
With all these in consideration, I am not updating the major version of the SDK. I am updating only the minor version. Please let me know your thoughts.
@ramya-rao-a Please review and approve