Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/identity readme azure -> Azure #12838

Merged
2 commits merged into from
Jan 26, 2021
Merged

@azure/identity readme azure -> Azure #12838

2 commits merged into from
Jan 26, 2021

Conversation

diberry
Copy link
Contributor

@diberry diberry commented Dec 9, 2020

No description provided.

@diberry
Copy link
Contributor Author

diberry commented Dec 9, 2020

#12836 - issue - @azure/identity npm package page - link to older auth libraries

@@ -211,6 +219,8 @@ Currently, the following client libraries support authenticating with `TokenCred
- [@azure/storage-blob](https://npmjs.com/package/@azure/storage-blob)
- [@azure/storage-queue](https://npmjs.com/package/@azure/storage-queue)

If you need to authenticate to a different service, use the [@azure/ms-rest-js](https://www.npmjs.com/package/@azure/ms-rest-js) client library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ms-rest-js is not used for auth, the alternatives would be to use ms-rest-nodeauth for node applications and ms-rest-browserauth for browser applications.

The list above is not complete. We have about 10 more packages that now work with Azure Identity.

Moreover, with the code generator updated as described in Azure/autorest.typescript#815, the Azure Identity library will be usable with all auto generated packages. So, I believe this clarification would not be needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to undo change to line 222 and remove package list right above it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in #13113

@@ -37,7 +37,7 @@ To authenticate in Visual Studio Code, first ensure the [Azure Account Extension

Applications using the `AzureCliCredential`, rather directly or via the `DefaultAzureCredential`, can use the Azure CLI account to authenticate calls in the application when running locally.

To authenticate with the [Azure CLI][azure_cli] users can run the command `az login`. For users running on a system with a default web browser the azure cli will launch the browser to authenticate the user.
To authenticate with the [Azure CLI][azure_cli] users can run the command `az login`. For users running on a system with a default web browser the Azure cli will launch the browser to authenticate the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for making this pull request. I appreciate the effort you're putting here! I like these casing on the Azure name, very necessary! Thanks!

@ramya-rao-a ramya-rao-a changed the title @azure/identity readme changes @azure/identity readme azure -> Azure Jan 26, 2021
@ghost
Copy link

ghost commented Jan 26, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 61bb0c1 into Azure:master Jan 26, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants