Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] - Add support for custom role operations #13470

Merged
merged 13 commits into from
Feb 1, 2021
Merged

[KeyVault] - Add support for custom role operations #13470

merged 13 commits into from
Feb 1, 2021

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Jan 28, 2021 •
edited
Loading

What

  • Regenerate swagger to the latest version (and pin it to a sha)
  • Add CRUD operations for custom role definitions
  • A few renames from API feedback in roleAssignment

Why

  • Now that the swagger is updated with the new RBAC operations we can add support for it

Todo

  • CHANGELOG
  • Audit all samples to ensure they're still up to date (and add samples for custom role definitions)

resolves #12206

@ghost ghost added the KeyVault label Jan 28, 2021
@maorleger maorleger force-pushed the 12206-custom-role-definitions branch from 183e5b1 to b39083d Compare January 28, 2021 23:27
sadasant
sadasant reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll hold off the approval since I know there are some updates coming.

@maorleger maorleger force-pushed the 12206-custom-role-definitions branch from 44ef1ee to e0d6234 Compare January 29, 2021 22:11
sadasant
sadasant approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙏

sdk/keyvault/keyvault-admin/review/keyvault-admin.api.md Outdated Show resolved Hide resolved
@maorleger maorleger merged commit 14ed4e7 into Azure:master Feb 1, 2021
@maorleger maorleger deleted the 12206-custom-role-definitions branch June 2, 2021 17:58
@maorleger maorleger mentioned this pull request Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant approved these changes

@christothes christothes Awaiting requested review from christothes

@heaths heaths Awaiting requested review from heaths

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

@sophiajt sophiajt Awaiting requested review from sophiajt

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom role definitions
5 participants
@maorleger @bterlson @sadasant @christothes @heaths