-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment version for new core packages, fix linter errors #13691
Changes from all commits
e01fa67
380755c
d239c4a
d833ec5
b12083a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
# Release History | ||
|
||
## 1.0.0-beta.2 (Unreleased) | ||
|
||
## 1.0.0-beta.1 (2021-02-04) | ||
|
||
- Changes from `core-http`: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
export const SDK_VERSION: string = "1.0.0-beta.1"; | ||
export const SDK_VERSION: string = "1.0.0-beta.2"; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,8 @@ function isArrayBuffer(body: any): body is ArrayBuffer | ArrayBufferView { | |
class ReportTransform extends Transform { | ||
private loadedBytes = 0; | ||
private progressCallback: (progress: TransferProgressEvent) => void; | ||
|
||
// eslint-disable-next-line @typescript-eslint/ban-types | ||
_transform(chunk: string | Buffer, _encoding: string, callback: Function): void { | ||
this.push(chunk); | ||
this.loadedBytes += chunk.length; | ||
|
@@ -127,7 +129,7 @@ export class NodeHttpsClient implements HttpsClient { | |
request | ||
}; | ||
|
||
let responseStream = shouldDecompress ? getDecodedResponseStream(res, headers) : res; | ||
responseStream = shouldDecompress ? getDecodedResponseStream(res, headers) : res; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xirzec This causes change in behavior. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like I didn't catch this problem when I reviewed #12038 -- nice find! |
||
|
||
const onDownloadProgress = request.onDownloadProgress; | ||
if (onDownloadProgress) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that work instead of disabling the rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are overriding a method from the parent class which we do not own. So, thought it best to not change the signature compared to the same method in the parent class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
may have came from the definition of _transform in base.d.ts.Would
(error?: Error) => void
be better? The doc says it must be anError
object if an error occurred.