Increment version for new core packages, fix linter errors

sdk/core/core-client/CHANGELOG.md

@@ -1,5 +1,7 @@
 # Release History
 
+## 1.0.0-beta.2 (Unreleased)
+
 ## 1.0.0-beta.1 (2021-02-04)
 
 - First release of package, see README.md for details.

sdk/core/core-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/core-client",
-  "version": "1.0.0-beta.1",
+  "version": "1.0.0-beta.2",
   "description": "Core library for interfacing with AutoRest generated code",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -40,7 +40,7 @@
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
-    "lint": "eslint package.json api-extractor.json src test --ext .ts -f html -o coreClient-lintReport.html || exit 0",
+    "lint": "eslint package.json api-extractor.json src test --ext .ts",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test:browser && npm run unit-test:browser && npm run integration-test:browser",

sdk/core/core-client/review/core-client.api.md

@@ -42,7 +42,7 @@ export interface ClientPipelineOptions extends InternalPipelineOptions {
         credential: TokenCredential;
     };
     deserializationOptions?: DeserializationPolicyOptions;
-    serializationOptions?: serializationPolicyOptions;
+    serializationOptions?: SerializationPolicyOptions;
 }
 
 // @public (undocumented)
@@ -309,13 +309,13 @@ export interface SequenceMapperType {
 }
 
 // @public
-export function serializationPolicy(options?: serializationPolicyOptions): PipelinePolicy;
+export function serializationPolicy(options?: SerializationPolicyOptions): PipelinePolicy;
 
 // @public
 export const serializationPolicyName = "serializationPolicy";
 
 // @public
-export interface serializationPolicyOptions {
+export interface SerializationPolicyOptions {
     serializerOptions?: SerializerOptions;
     stringifyXML?: (obj: any, opts?: XmlOptions) => string;
 }

sdk/core/core-client/src/deserializationPolicy.ts

@@ -184,9 +184,9 @@ async function deserializeResponseBody(
           valueToDeserialize,
           "operationRes.parsedBody"
         );
-      } catch (error) {
+      } catch (deserializeError) {
         const restError = new RestError(
-          `Error ${error} occurred in deserializing the responseBody - ${parsedResponse.bodyAsText}`,
+          `Error ${deserializeError} occurred in deserializing the responseBody - ${parsedResponse.bodyAsText}`,
           {
             statusCode: parsedResponse.status,
             request: parsedResponse.request,

sdk/core/core-client/src/index.ts

@@ -54,5 +54,5 @@ export {
 export {
   serializationPolicy,
   serializationPolicyName,
-  serializationPolicyOptions
+  SerializationPolicyOptions
 } from "./serializationPolicy";

sdk/core/core-client/src/serializationPolicy.ts

@@ -28,7 +28,7 @@ export const serializationPolicyName = "serializationPolicy";
 /**
  * Options to configure API request serialization.
  */
-export interface serializationPolicyOptions {
+export interface SerializationPolicyOptions {
   /**
    * A function that is able to write XML. Required for XML support.
    */
@@ -44,7 +44,7 @@ export interface serializationPolicyOptions {
  * This policy handles assembling the request body and headers using
  * an OperationSpec and OperationArguments on the request.
  */
-export function serializationPolicy(options: serializationPolicyOptions = {}): PipelinePolicy {
+export function serializationPolicy(options: SerializationPolicyOptions = {}): PipelinePolicy {
   const stringifyXML = options.stringifyXML;
 
   return {
@@ -66,7 +66,7 @@ function serializeHeaders(
   request: OperationRequest,
   operationArguments: OperationArguments,
   operationSpec: OperationSpec
-) {
+): void {
   if (operationSpec.headerParameters) {
     for (const headerParameter of operationSpec.headerParameters) {
       let headerValue = getOperationArgumentValueFromParameter(operationArguments, headerParameter);

sdk/core/core-client/src/serializer.ts

@@ -817,7 +817,7 @@ function getXmlObjectValue(
   serializedValue: any,
   isXml: boolean,
   options: RequiredSerializerOptions
-) {
+): any {
   if (!isXml || !propertyMapper.xmlNamespace) {
     return serializedValue;
   }

sdk/core/core-client/src/serviceClient.ts

@@ -26,7 +26,7 @@ import { getRequestUrl } from "./urlHelpers";
 import { isPrimitiveType } from "./utils";
 import { deserializationPolicy, DeserializationPolicyOptions } from "./deserializationPolicy";
 import { URL } from "./url";
-import { serializationPolicy, serializationPolicyOptions } from "./serializationPolicy";
+import { serializationPolicy, SerializationPolicyOptions } from "./serializationPolicy";
 import { getCachedDefaultHttpsClient } from "./httpClientCache";
 import { getOperationRequestInfo } from "./operationHelpers";
 
@@ -124,7 +124,7 @@ export class ServiceClient {
 
   /**
    * Send an HTTP request that is populated using the provided OperationSpec.
-   * @typeParam T The typed result of the request, based on the OperationSpec.
+   * @typeParam T - The typed result of the request, based on the OperationSpec.
    * @param operationArguments - The arguments that the HTTP request's templated values will be populated from.
    * @param operationSpec - The OperationSpec to use to populate the httpRequest.
    */
@@ -261,7 +261,7 @@ export interface ClientPipelineOptions extends InternalPipelineOptions {
   /**
    * Options to customize serializationPolicy.
    */
-  serializationOptions?: serializationPolicyOptions;
+  serializationOptions?: SerializationPolicyOptions;
 }
 
 /**

sdk/core/core-client/src/utils.ts

@@ -7,7 +7,7 @@
  * @param value - Value to test
  * @hidden @internal
  */
-export function isPrimitiveType(value: any): boolean {
+export function isPrimitiveType(value: unknown): boolean {
   return (typeof value !== "object" && typeof value !== "function") || value === null;
 }
 

sdk/core/core-client/test/serviceClient.spec.ts

@@ -271,7 +271,7 @@ describe("ServiceClient", function() {
 
     let rawResponse: FullOperationResponse | undefined;
 
-    const response = await client.sendOperationRequest(
+    const operationResponse = await client.sendOperationRequest(
       { options: { onResponse: (response) => (rawResponse = response) } },
       {
         httpMethod: "GET",
@@ -285,7 +285,7 @@ describe("ServiceClient", function() {
     );
 
     assert(request!);
-    assert.strictEqual(JSON.stringify(response), "{}");
+    assert.strictEqual(JSON.stringify(operationResponse), "{}");
     assert.strictEqual(rawResponse?.status, 200);
     assert.strictEqual(rawResponse?.request, request!);
     assert.strictEqual(rawResponse?.headers.get("X-Extra-Info"), "foo");

sdk/core/core-https/CHANGELOG.md

@@ -1,5 +1,7 @@
 # Release History
 
+## 1.0.0-beta.2 (Unreleased)
+
 ## 1.0.0-beta.1 (2021-02-04)
 
 - Changes from `core-http`:

sdk/core/core-https/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/core-https",
-  "version": "1.0.0-beta.1",
+  "version": "1.0.0-beta.2",
   "description": "Isomorphic client library for making HTTPS requests in node.js and browser.",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -45,7 +45,7 @@
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
-    "lint": "eslint package.json api-extractor.json src test --ext .ts -f html -o coreHttps-lintReport.html || exit 0",
+    "lint": "eslint package.json api-extractor.json src test --ext .ts",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test:browser && npm run unit-test:browser && npm run integration-test:browser",

sdk/core/core-https/src/constants.ts

@@ -1,4 +1,4 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export const SDK_VERSION: string = "1.0.0-beta.1";
+export const SDK_VERSION: string = "1.0.0-beta.2";

sdk/core/core-https/src/nodeHttpsClient.ts

@@ -39,6 +39,8 @@ function isArrayBuffer(body: any): body is ArrayBuffer | ArrayBufferView {
 class ReportTransform extends Transform {
   private loadedBytes = 0;
   private progressCallback: (progress: TransferProgressEvent) => void;
+
+  // eslint-disable-next-line @typescript-eslint/ban-types
   _transform(chunk: string | Buffer, _encoding: string, callback: Function): void {
     this.push(chunk);
     this.loadedBytes += chunk.length;
@@ -127,7 +129,7 @@ export class NodeHttpsClient implements HttpsClient {
             request
           };
 
-          let responseStream = shouldDecompress ? getDecodedResponseStream(res, headers) : res;
+          responseStream = shouldDecompress ? getDecodedResponseStream(res, headers) : res;
 
           const onDownloadProgress = request.onDownloadProgress;
           if (onDownloadProgress) {

sdk/core/core-https/src/pipeline.ts

@@ -182,11 +182,11 @@ class HttpsPipeline implements Pipeline {
 
     const pipeline = policies.reduceRight<SendRequest>(
       (next, policy) => {
-        return (request: PipelineRequest) => {
-          return policy.sendRequest(request, next);
+        return (req: PipelineRequest) => {
+          return policy.sendRequest(req, next);
         };
       },
-      (request: PipelineRequest) => httpsClient.sendRequest(request)
+      (req: PipelineRequest) => httpsClient.sendRequest(req)
     );
 
     return pipeline(request);
@@ -346,7 +346,7 @@ class HttpsPipeline implements Pipeline {
       }
     }
 
-    function walkPhases() {
+    function walkPhases(): void {
       let noPhaseRan = false;
 
       for (const phase of orderedPhases) {

sdk/core/core-https/src/policies/bearerTokenAuthenticationPolicy.ts

@@ -34,10 +34,10 @@ export function bearerTokenAuthenticationPolicy(
 ): PipelinePolicy {
   const { credential, scopes } = options;
   const tokenCache: AccessTokenCache = new ExpiringAccessTokenCache();
-  async function getToken(options: GetTokenOptions): Promise<string | undefined> {
+  async function getToken(tokenOptions: GetTokenOptions): Promise<string | undefined> {
     let accessToken = tokenCache.getCachedToken();
     if (accessToken === undefined) {
-      accessToken = (await credential.getToken(scopes, options)) || undefined;
+      accessToken = (await credential.getToken(scopes, tokenOptions)) || undefined;
       tokenCache.setCachedToken(accessToken);
     }
 

sdk/core/core-https/src/util/sanitizer.ts

@@ -91,7 +91,7 @@ export class Sanitizer {
     this.allowedQueryParameters = new Set(allowedQueryParameters.map((p) => p.toLowerCase()));
   }
 
-  public sanitize(obj: object): string {
+  public sanitize(obj: unknown): string {
     return JSON.stringify(obj, this.replacer.bind(this), 2);
   }
 

sdk/core/core-https/src/xhrHttpsClient.ts

@@ -93,7 +93,7 @@ function handleBlobResponse(
   request: PipelineRequest,
   res: (value: PipelineResponse | PromiseLike<PipelineResponse>) => void,
   rej: (reason?: any) => void
-) {
+): void {
   xhr.addEventListener("readystatechange", () => {
     // Resolve as soon as headers are loaded
     if (xhr.readyState === XMLHttpRequest.HEADERS_RECEIVED) {