Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-client] Clean up serviceClient.ts by moving code #13699

Merged
4 commits merged into from
Feb 9, 2021
Merged

[core-client] Clean up serviceClient.ts by moving code #13699

4 commits merged into from
Feb 9, 2021

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Feb 9, 2021

This PR makes no actual code changes, but moves some code out of serviceClient.ts to make the file a little less sprawling.

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Feb 9, 2021
@xirzec xirzec self-assigned this Feb 9, 2021
@ramya-rao-a
Copy link
Contributor

Can we ensure this gets merged after #13691 so that all net changes in git history appear after the version number was incremented?

@xirzec
Copy link
Member Author

xirzec commented Feb 9, 2021

Can we ensure this gets merged after #13691 so that all net changes in git history appear after the version number was incremented?

Yep! I just approved that one so we can get it merged first. :)

@ramya-rao-a
Copy link
Contributor

Yep! I just approved that one so we can get it merged first. :)

Yay! And with that you get awarded with a merge conflict! Congratulations!

@xirzec
Copy link
Member Author

xirzec commented Feb 9, 2021

Yay! And with that you get awarded with a merge conflict! Congratulations!

I will treasure it, thank you. 😉

jeremymeng
jeremymeng approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Love cleaner code

@ghost
Copy link

ghost commented Feb 9, 2021

Hello @xirzec!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@xirzec
Copy link
Member Author

xirzec commented Feb 9, 2021

/check-enforcer reset

@xirzec
Copy link
Member Author

xirzec commented Feb 9, 2021

/check-enforcer evaluate

@ghost ghost merged commit d5a1df0 into Azure:master Feb 9, 2021
@xirzec xirzec deleted the reorganizeClient branch February 9, 2021 19:51
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 31, 2021
CodeGen from PR 13699 in Azure/azure-rest-api-specs
127a73d 
LabServices readme.python t2 config(wave4) (Azure#13699)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@xirzec xirzec

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xirzec @ramya-rao-a @jeremymeng