-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-client] Clean up serviceClient.ts by moving code #13699
Conversation
Can we ensure this gets merged after #13691 so that all net changes in git history appear after the version number was incremented? |
Yep! I just approved that one so we can get it merged first. :) |
Yay! And with that you get awarded with a merge conflict! Congratulations! |
I will treasure it, thank you. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Love cleaner code
Hello @xirzec! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
/check-enforcer reset |
/check-enforcer evaluate |
LabServices readme.python t2 config(wave4) (Azure#13699)
This PR makes no actual code changes, but moves some code out of
serviceClient.ts
to make the file a little less sprawling.