-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-http] terminate connection when download stream is closed #14015
Merged
jeremymeng
merged 11 commits into
Azure:main
from
jeremymeng:core-http-close-connection
Oct 11, 2021
Merged
[core-http] terminate connection when download stream is closed #14015
jeremymeng
merged 11 commits into
Azure:main
from
jeremymeng:core-http-close-connection
Oct 11, 2021
Commits on Feb 26, 2021
-
[core-http] terminate connection when upload/download stream is closed
The issue is that when the stream is closed explicitly by `stream.destroy()` call, we don't ask the underlying transportation layer to cancel the request, thus leaving network connection to service open which could cause resource exhaustion. Addresses Azure#11850
Configuration menu - View commit details
-
Copy full SHA for 15ac134 - Browse repository at this point
Copy the full SHA 15ac134View commit details
Commits on Sep 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b4e71d3 - Browse repository at this point
Copy the full SHA b4e71d3View commit details -
Don't abort upload stream on stream close event
as the uploading might still be in progress.
Configuration menu - View commit details
-
Copy full SHA for 3c4b0d8 - Browse repository at this point
Copy the full SHA 3c4b0d8View commit details
Commits on Sep 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 507d33f - Browse repository at this point
Copy the full SHA 507d33fView commit details
Commits on Sep 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2ad1f93 - Browse repository at this point
Copy the full SHA 2ad1f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e463c - Browse repository at this point
Copy the full SHA c5e463cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac9c9c - Browse repository at this point
Copy the full SHA 3ac9c9cView commit details
Commits on Oct 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9a79799 - Browse repository at this point
Copy the full SHA 9a79799View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9935b4 - Browse repository at this point
Copy the full SHA d9935b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a87d5 - Browse repository at this point
Copy the full SHA 63a87d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e4642 - Browse repository at this point
Copy the full SHA 97e4642View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.