Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event-hubs] migrate samples to v2 #15053

Merged
13 commits merged into from
Jun 25, 2021
Merged

[event-hubs] migrate samples to v2 #15053

13 commits merged into from
Jun 25, 2021

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Apr 28, 2021

Followed the steps at https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide
/cc @willmtemple

Note: I moved browserSamples and expressSamples into the generated v5 samples folder since dev-tool doesn't work with those.

Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the samples/browserSample directory, what I suggest is to move it to samples-browser and create an entry in //sampleConfiguration to copy it into the samples/v5 directory, next to javascript and typescript during the publication script. This isn't yet documented in the migration guide, but the capability is available through the extraFiles property: #14576

I'd really like to find a new home for the express sample at some point, but for now we could do the same thing with it or leave the manual copy you created.

@chradek
Copy link
Contributor Author

chradek commented May 20, 2021

Updated, thanks for the tips @willmtemple!

@ramya-rao-a
Copy link
Contributor

/azp run js - eventhub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Contributor

@chradek Looks like what we have is a bunch of broken links

image

@chradek
Copy link
Contributor Author

chradek commented Jun 11, 2021

@ramya-rao-a Now it is fixed! If you wait for #15137 to be merged then you can leave me to deal with the fallout of broken links/merge conflicts.

@ramya-rao-a
Copy link
Contributor

#15137 is merged! Happy merge conflicts to you!

@chradek
Copy link
Contributor Author

chradek commented Jun 24, 2021

/azp run js - eventhub - ci

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 15053 in repo Azure/azure-sdk-for-js

@ramya-rao-a
Copy link
Contributor

Looks like there are a few more broken links...

@chradek
Copy link
Contributor Author

chradek commented Jun 25, 2021

Oh no...I fixed all the merge conflicts then reran the dev-tool publish script and it overwrote the links from main back to master.

Edit: I use worktrees, so I think the dev-tool I installed previously was linked to the one in my master branch, so didn't pick up the changes from master to main. I reinstalled dev-tool and now it's generating the right links.

@chradek
Copy link
Contributor Author

chradek commented Jun 25, 2021

/azp run js - eventhub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jun 25, 2021

Hello @chradek!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ghost ghost merged commit 2f90a87 into Azure:main Jun 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants