Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node v8 from run matrix #15647

Merged
merged 1 commit into from
Jun 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions eng/pipelines/templates/jobs/smoke.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ jobs:
condition: and(succeeded(), eq(dependencies.smoke_test_eligibility.outputs['check_smoke_tests.RunSmokeTests'], true))
strategy:
matrix:
Linux Node8 (AzureCloud):
Pool: Azure Pipelines
OSVmImage: "macOS-10.14"
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
ArmTemplateParameters: $(AzureCloudArmTemplateParameters)
NodeTestVersion: "8.x"
Mac Node10 (AzureCloud):
Pool: Azure Pipelines
OSVmImage: "macOS-10.14"
Expand Down Expand Up @@ -192,15 +186,9 @@ jobs:
displayName: List packages installed from the feed

- script: npm run smoke-test -- --devops-logging
condition: and(succeeded(), ne(variables.NodeTestVersion, '8.x'))
workingDirectory: common/smoke-test/
displayName: Run smoke tests

- script: npm run smoke-test-node8 -- --devops-logging
condition: and(succeeded(), eq(variables.NodeTestVersion, '8.x'))
workingDirectory: common/smoke-test/
displayName: Run smoke tests (Node 8)

- template: /eng/common/TestResources/remove-test-resources.yml
parameters:
SubscriptionConfiguration: $(SubscriptionConfiguration)
2 changes: 1 addition & 1 deletion eng/pipelines/templates/stages/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" },
"macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" }
},
"NodeTestVersion": [ "8.x", "10.x", "12.x", "14.x", "16.x" ],
"NodeTestVersion": [ "10.x", "12.x", "14.x", "16.x" ],
"TestType": "node",
"TestResultsFiles": "**/test-results.xml"
},
Expand Down