[Storage] Use ES2017

[deyaaeldeen]

Fixes #15640
Fixes #15671

Updates core-http, core-lro, and storage packages to compile to ES2017.

[ramya-rao-a]

With this change, are all Track 2 packages in our repo now targeting ES2017?
If so, then do we need to mention it in the tsconfig file for each package or can we update it in the root tsconfig file?

[deyaaeldeen]

@ramya-rao-a yes all of them target ES2017. @xirzec already updated the root tsconfig file.

I have it explicit in some packages because for some reason they do not extend the root tsconfig and I am not sure why.

[xirzec]

I'm good with this change, but I think we need to bump some versions as part of it

[deyaaeldeen]

This was done before for reasons that @witemple-msft does not remember and it is causing the storage-file-datalake samples to fail compiling because storage-common is just a simple folder of source files instead of being a package with a package.json (unlike keyvault-common) so compiled files there do not have access to tslib.

[deyaaeldeen]

this was needed because it depends on core-http. There is no need to bump the version I believe since it is still in beta.

[xirzec]

I'm good with this change, but we should make sure to merge this and #15925 at the same time.

Also we should get the Storage team to sign off before merging.

[ramya-rao-a]

Update:

I have pushed a few commits to keep the version updates of the core packages out of this PR.
We will be doing that as part of #15925 where we will update both core-http and core-lro

[ramya-rao-a]

@EmmaZhu, @XiaoningLiu, @ljian3377, We are going ahead with this change to standardize the target in tsconfig file as we have other PRs waiting on this. Please use #15671 to discuss any concerns you have here. We are doing a minor version update as this is not a bug fix.