[core-rest-pipeline] Fix handling of typed arrays in request bodies #15904
Conversation
NodeJS does not support directly passing typed arrays or ArrayBuffers to `http.ClientRequest` streams. This means we must correctly wrap these types in a `Buffer` for them to be serialized correctly.
xirzec
added
Client
| } else if (isArrayBuffer(body)) { | ||
| req.end(ArrayBuffer.isView(body) ? Buffer.from(body.buffer) : Buffer.from(body)); | ||
| } else { | ||
| logger.error("Unrecognized body type", body); |
There was a problem hiding this comment.
This is basically a "never" situation since:
FormDatawould be handled by theisReadableStreamcase aboveBlobis browser only
There are no other supported body types after that.
There was a problem hiding this comment.
How is FormData handled by isReadableStream? It doesn't have pipe function. also I had thought it's browser only (go to definition opens lib.dom.d.ts) and I didn't find it in nodejs docs.
There was a problem hiding this comment.
FormData (the type you saw) gets converted by this policy when in Node:
It uses an npm package form-data to create another object type (confusingly also called FormData) that implements the Stream interface.
There was a problem hiding this comment.
Thanks for the fix! I did not know about typed arrays until now, found this to be a useful intro: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray
As you might expect, they're useful for code that is performance-critical since they should have compact memory representation and operations on them should be fast.
delete python track1 config (Azure#15904)
delete python track1 config (Azure#15904)
delete python track1 config (Azure#15904)
NodeJS does not support directly passing typed arrays or ArrayBuffers to
http.ClientRequeststreams. This means we must correctly wrap these types in aBufferfor them to be serialized correctly.