Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] - GA core-rest-pipeline 1.1.0 #15923

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

maorleger
Copy link
Member

What

  • Update @azure/core-rest-pipeline to 1.1.0 from beta
  • Update dependencies to the latest version
  • Update everyone to the same version of @azure/core-tracing

Why

Now that we used the CAE capabilities added in core-rest-pipeline in both container registry and key vault it's time to GA this version! It also unblocks our efforts to get everyone upgraded to the latest core-tracing (and OTel by extension) versions.

@@ -86,7 +86,7 @@
"dependencies": {
"@azure/core-auth": "^1.3.0",
"@azure-rest/core-client": "1.0.0-beta.4",
"@azure/core-rest-pipeline": "^1.0.3",
"@azure/core-rest-pipeline": "^1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a REST level client and so this file is auto generated. Therefore, we should update the code gen as well. Can we get an issue logged at https://github.com/Azure/autorest.typescript/issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you could pile on to Azure/autorest.typescript#1048

cc @sarangan12

@maorleger
Copy link
Member Author

@southpolesteve @zfoster looks like the cosmos emulator has failed to start on multiple runs. Is that a known issue?

@zfoster
Copy link
Contributor

zfoster commented Jun 23, 2021

yeah, @jeremymeng asked me to take a look and I said I can end of this week

@maorleger
Copy link
Member Author

Thanks @zfoster ! I created #15928 so we can track moving cosmos over, but there's no harm in leaving you against core-rest-pipeline ^1.0.3 for now to unblock this PR

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@maorleger maorleger merged commit 99d53b6 into Azure:main Jun 23, 2021
@maorleger maorleger deleted the core-rest-pipeline-ga branch June 23, 2021 20:49
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 6, 2021
Update readme and readme python (Azure#15923)

* Update readme and readme python

* Update readme.python.md

Co-authored-by: msyyc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants