Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Monitor Exporter] Updating OpenTelemetry API to 1.0.0 #15934

Merged
merged 6 commits into from
Jun 24, 2021

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg commented Jun 23, 2021

Updating other dependencies to compatible version
https://github.com/open-telemetry/opentelemetry-js#compatibility-matrix

Related to #15883 and #15925

@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 23, 2021
@hectorhdzg
Copy link
Member Author

@KarishmaGhiya updated Monitor Query package as well because there were compilation errors triggered, let me know if this fine.

Invoking: tsc -p . && npm run lint && npm run build:nodebrowser && api-extractor run --local && npm run build:types

test/setupOpenTelemetry.ts(35,53): error TS2345: Argument of type 'AzureMonitorTraceExporter' is not assignable to parameter of type 'SpanExporter'.
Types of property 'export' are incompatible.
Type '(spans: ReadableSpan[], resultCallback: (result: ExportResult) => void) => Promise' is not assignable to type '(spans: ReadableSpan[], resultCallback: (result: ExportResult) => void) => void'.
Types of parameters 'spans' and 'spans' are incompatible.
Type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@opentelemetry/[email protected]/node_modules/@opentelemetry/tracing/build/src/export/ReadableSpan").ReadableSpan[]' is not assignable to type 'import("/mnt/vss/work/1/s/common/temp/node_modules/.pnpm/@opentelemetry/[email protected]@opentelemetry[email protected]/node_modules/@opentelemetry/tracing/build/src/export/ReadableSpan").ReadableSpan[]'.
Type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@opentelemetry/[email protected]/node_modules/@opentelemetry/tracing/build/src/export/ReadableSpan").ReadableSpan' is not assignable to type 'import("/mnt/vss/work/1/s/common/temp/node_modules/.pnpm/@opentelemetry/[email protected]@opentelemetry[email protected]/node_modules/@opentelemetry/tracing/build/src/export/ReadableSpan").ReadableSpan'.
Types of property 'spanContext' are incompatible.
Type 'SpanContext' is not assignable to type '() => SpanContext'.
Type 'SpanContext' provides no match for the signature '(): SpanContext'.

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarishmaGhiya, I'm okay with the monitor-query changes unless you have any objections?

@hectorhdzg hectorhdzg merged commit 24302c8 into Azure:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants