Update Node.js & browser support in README #16011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
chradek,
deyaaeldeen,
ellismg,
EmmaZhu,
HarshaNalluru,
hectorhdzg,
jeremymeng,
jiacfan,
joheredi,
KarishmaGhiya,
LarryOsterman,
ljian3377,
maorleger,
mikeharder,
praveenkuttappan,
richardpark-msft,
sadasant,
sarangan12,
schaabs,
southpolesteve,
vinjiang,
vishnureddy17,
witemple-msft,
XiaoningLiu,
xirzec,
YoDaMa and
zfoster
as code owners
ghost
added
Azure.Identity
KeyVault
Storage
zfoster
approved these changes
Jun 25, 2021
HarshaNalluru
approved these changes
Jun 25, 2021
hectorhdzg
reviewed
Jun 25, 2021
sdk/monitor/monitor-opentelemetry-exporter/samples/@azure/storage-blob/javascript/README.md
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Jun 25, 2021
sdk/monitor/monitor-opentelemetry-exporter/samples/@azure/storage-blob/typescript/README.md
Outdated
Show resolved
Hide resolved
ellismg
approved these changes
Jun 25, 2021
deyaaeldeen
reviewed
Jun 25, 2021
hectorhdzg
approved these changes
Jun 25, 2021
jeremymeng
approved these changes
Jun 25, 2021
| @@ -37,7 +37,7 @@ This sample demonstrates a few alternatives to integrating with Azure Key Vault | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| The sample is compatible with Node.js >= 8.0.0 | |||
| The sample is compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/) | |||
There was a problem hiding this comment.
nit: missing period
Suggested change
| The sample is compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/) | |
| The sample is compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/). |
| @@ -9,7 +9,7 @@ In this sample, we build a simple [Electron][electron] application and integrati | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| The samples are compatible with Node.js >= 8.0.0. | |||
| The samples are compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/) | |||
There was a problem hiding this comment.
nit: missing period
Suggested change
| The samples are compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/) | |
| The samples are compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/). |
| ### Prerequisites | ||
|
|
||
| - An [Azure subscription](https://azure.microsoft.com/free/) | ||
| - A[Key Vault resource](https://docs.microsoft.com/azure/key-vault/quick-create-portal) |
There was a problem hiding this comment.
Suggested change
| - A[Key Vault resource](https://docs.microsoft.com/azure/key-vault/quick-create-portal) | |
| - A [Key Vault resource](https://docs.microsoft.com/azure/key-vault/quick-create-portal) |
|
Thanks @jeremymeng, I'll add the missing periods and spaces in a separate PR CI for all is green except cosmos which is a known issue and @zfoster is on it |
|
/check-enforcer override |
This was referenced Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #7022, we need to update the README of all our packages to ensure our support policy is up to date.
Net changes in this PR:
supported environmentsandprerequesitesThis PR intentionally focuses only on the readme file.
There will be a separate PR updating the
enginesfield and the version of@types/nodein the package.json files.Ask on package owners: Speak up if your readme file in this PR states browser support but your package does not really work in the browser or the other way around