Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Analytics] Allow up to one action only per type #16114

Conversation

deyaaeldeen
Copy link
Member

Because the service currently support one action only per type except for PII actions. However they plan to disable multiple actions for PII as well within a month. This PR does client-side checking for this across types and throw a meaningful error message. This limitation will be relaxed in the next service preview version.

Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth including this behavior change in changelog as well

Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for it?

@deyaaeldeen
Copy link
Member Author

@kristapratico and @maririos done, thanks for the feedback!

@ghost
Copy link

ghost commented Jun 30, 2021

Hello @deyaaeldeen!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 26ccf7a into Azure:feature/textanalytics/3.1 Jun 30, 2021
ghost pushed a commit that referenced this pull request Jun 30, 2021
@deyaaeldeen deyaaeldeen deleted the textanalytics/disable-multiple-tasks branch June 30, 2021 23:18
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 22, 2021
[servicebus]Update readme.python.md (Azure#16114)

* Update readme.python.md

* Update readme.python.md
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 22, 2021
[servicebus]Update readme.python.md (Azure#16114)

* Update readme.python.md

* Update readme.python.md
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 23, 2021
[servicebus]Update readme.python.md (Azure#16114)

* Update readme.python.md

* Update readme.python.md
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 23, 2021
[servicebus]Update readme.python.md (Azure#16114)

* Update readme.python.md

* Update readme.python.md
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants