-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock react native support when using corev2 packages #17783
Changes from 3 commits
88a219c
5b57c64
e9919b9
2d48ab4
c4b7435
7425dc8
5db944c
73356b8
dee0d6f
8e590d2
ef06c5e
105664a
6b5e878
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,9 @@ | |
"./dist-esm/src/util/inspect.js": "./dist-esm/src/util/inspect.browser.js", | ||
"./dist-esm/src/util/url.js": "./dist-esm/src/util/url.browser.js" | ||
}, | ||
"react-native": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since react native support will be only part of core-v2, should we add the mapping here? |
||
"./dist/index.js": "./dist-esm/src/index.js" | ||
}, | ||
"license": "MIT", | ||
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-http/README.md", | ||
"repository": "github:Azure/azure-sdk-for-js", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,10 @@ | |
"./dist-esm/src/util/url.js": "./dist-esm/src/util/url.browser.js", | ||
"./dist-esm/src/util/userAgentPlatform.js": "./dist-esm/src/util/userAgentPlatform.browser.js" | ||
}, | ||
"react-native": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changelog? |
||
"./dist/index.js": "./dist-esm/src/index.js", | ||
"./dist-esm/src/util/userAgentPlatform.js": "./dist-esm/src/util/userAgentPlatform.native.js" | ||
}, | ||
"types": "core-rest-pipeline.shims.d.ts", | ||
"typesVersions": { | ||
"<3.6": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
/* | ||
* NOTE: When moving this file, please update "browser" section in package.json. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. browser -> react-native? |
||
*/ | ||
|
||
/** | ||
* @internal | ||
*/ | ||
export function getHeaderName(): string { | ||
return "x-ms-useragent"; | ||
} | ||
|
||
/** | ||
* @internal | ||
*/ | ||
export function setPlatformSpecificData(map: Map<string, string>): void { | ||
// TODO: Investigate using `import { Platform } from "react-native"` to get "OS" and "Version". | ||
// This may bring in a lot of overhead if we have to use this package directly, perhaps we can shim | ||
// types. | ||
map.set("OS", `react-native`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joheredi is this package still a dep in the rest clients? if not, we could probably skip updating it. Same applies for the lro one.