labservices-track1 #18156
Merged
labservices-track1 #18156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colawwj
requested review from
deyaaeldeen,
dw511214992,
qiaozha and
witemple-msft
as code owners
|
@colawwj - Changes LGTM, but please hold release until 11/8 to align with new API version rollout. |
|
@nickdepinet I see there're a lot of operations get removed. Are you sure it's expected https://github.com/Azure/azure-sdk-for-js/pull/18156/files#diff-aba890a18c105b53ea64abbb122d701370468bc6fdf7759e3372c2d704a6a8e6L43-L51 |
|
Yes, this is expected - this is a large change release for us. Can we change the release date from 11/8 to 11/22 to align with customer communications + blog posts? |
qiaozha
approved these changes
Dec 6, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 20, 2022
Add new apis for test button feature (Azure#18156) * Add new apis for test button feature * Fix bug * Revert to old package version * Fix errors * Fix errors * Fix error * Remove " * Only include the actiongroups changes in this new tag as per Dapeng. * Revert "Only include the actiongroups changes in this new tag as per Dapeng." This reverts commit 529a149b258dfa8dc8dcc52b6e1fea16ab2b40d6. * Add "x-ms-identifiers": [], * Update the default tag * Add location headers * No need to return response * build * build * format json * Prettier check Co-authored-by: Thomas Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.