-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rollup] - Fix bug in circular dependency warning suppression #19012
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e88cd20
anomaly-detector
maorleger 3936485
appconfiguration
maorleger f4ca0e8
digital-twins
maorleger 488f3b9
communication-remove bug only
maorleger 7a43ffe
eventgrid
maorleger 4505c51
eventhubs
maorleger 4bb9b87
event-processor-host
maorleger a5aa46e
eventhubs-checkpointstore
maorleger aef59bf
quantum-jobs
maorleger 11a37e0
add eventEmitter
maorleger 083b339
eventhubs-checkpointstore
maorleger 9784ef2
Search-documents
maorleger ad07884
servicebus
maorleger d02bc32
pnpm
maorleger d3ffa3c
some cleanup
maorleger 5f7d581
dt cleanup
maorleger 0f0e24f
eph
maorleger 0f298aa
fix appconfig paths
maorleger 59c4d13
restore app-config to previous
maorleger cec45a9
fix circular dep suppression
maorleger fdf0c1f
Update rollup.base.config.js
maorleger 4417cfc
fix format
maorleger 49695fa
remove otel-commonjs
maorleger 601ca06
dont change timeouts unnecessarily
maorleger 02b7ef7
fixup! dont change timeouts unnecessarily
maorleger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137 changes: 0 additions & 137 deletions
137
sdk/anomalydetector/ai-anomaly-detector/rollup.base.config.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,3 @@ | ||
import * as base from "./rollup.base.config"; | ||
import { makeConfig } from "@azure/dev-tool/shared-config/rollup"; | ||
|
||
const inputs = []; | ||
|
||
if (!process.env.ONLY_BROWSER) { | ||
inputs.push(base.nodeConfig()); | ||
} | ||
|
||
if (!process.env.ONLY_NODE) { | ||
inputs.push(base.browserConfig()); | ||
} | ||
|
||
export default inputs; | ||
export default makeConfig(require("./package.json")); |
3 changes: 0 additions & 3 deletions
3
sdk/anomalydetector/ai-anomaly-detector/rollup.test.config.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the definition of
openTelemetryCommonJs
should be deleted too if it is no longer needed.I wonder who uses
events
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
events
started out in the template package and my guess is that it got copied around :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close to being able to remove this crud - I just know that every rollup file imports this method and uses it, so rather than increasing the PR size I opted to leave the definiton. But I will log a separate issue for me to remove it (here and everywhere that has it)