[core-xml] Update fxp to v4 #19898
Merged
[core-xml] Update fxp to v4 #19898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
deyaaeldeen,
jeremymeng,
mikeharder,
praveenkuttappan,
witemple-msft and
xirzec
as code owners
ghost
added
the
xirzec
approved these changes
Jan 19, 2022
| @@ -66,7 +66,7 @@ | |||
| "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", | |||
| "dependencies": { | |||
| "tslib": "^2.2.0", | |||
| "fast-xml-parser": "^3.20.0" | |||
| "fast-xml-parser": "^4.0.1" | |||
There was a problem hiding this comment.
should we also bump the minor version of core-xml?
There was a problem hiding this comment.
Yeah, good point. I'll bump it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklists
Packages impacted by this PR:
@azure/core-xml
Issues associated with this PR:
#19607
Describe the problem that is addressed by this PR:
FXP has a new stable version, updating and adapting to the new version breaking changes. No breaking changes resulted for our API surface.