Add catch-all parameter to test resources script #20265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
requested review from
mikeharder,
praveenkuttappan and
weshaggard
as code owners
benbp
added
the
Central-EngSys
|
...wrong repository... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
New-TestResources.ps1script to not fail when extra unused parameters are passed in. This prevents the script from breaking if new keys/values are added to the subscription config object in keyvault (which gets splatted onto the script parameters here). Currently this is a problem with historical versions of the script that get run as part of a backport to a hotfix/release branch, where the old version of the script is not compatible with the subscription configuration parameters.For example, the addition of
ProvisionerApplicationOidhere is causing issues for live test pipeline runs using eng/common code older than the change as the parameter was also added to the subscription configuration.