Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleasePR @azure/arm-recoveryservices] [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-06-01 #21598

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 10 additions & 11 deletions sdk/recoveryservices/arm-recoveryservices/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
# Release History

## 5.0.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes


## 5.1.0 (2022-04-26)

**Features**

- Added Type Alias BackupStorageVersion
- Interface VaultProperties has a new optional parameter backupStorageVersion
- Added Enum KnownBackupStorageVersion


## 5.0.0 (2021-12-10)

The package of @azure/arm-recoveryservices is using our next generation design principles since version 5.0.0, which contains breaking changes.
Expand Down
2 changes: 1 addition & 1 deletion sdk/recoveryservices/arm-recoveryservices/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021 Microsoft
Copyright (c) 2022 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
7 changes: 4 additions & 3 deletions sdk/recoveryservices/arm-recoveryservices/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"commit": "76f8e0c50629ef12aa338d55782278ceca46212a",
"commit": "b92952589466e6f1878b5bf123d3a93f2cdd1edd",
"readme": "specification/recoveryservices/resource-manager/readme.md",
"autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md --use=@autorest/[email protected].20211130.1",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md --use=@autorest/[email protected].20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/[email protected]"
"release_tool": "@azure-tools/[email protected]",
"use": "@autorest/[email protected]"
}
25 changes: 19 additions & 6 deletions sdk/recoveryservices/arm-recoveryservices/api-extractor.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"mainEntryPointFilePath": "./dist-esm/src/index.d.ts",
"docModel": { "enabled": true },
"apiReport": { "enabled": true, "reportFolder": "./review" },
"docModel": {
"enabled": true
},
"apiReport": {
"enabled": true,
"reportFolder": "./review"
},
"dtsRollup": {
"enabled": true,
"untrimmedFilePath": "",
"publicTrimmedFilePath": "./types/arm-recoveryservices.d.ts"
},
"messages": {
"tsdocMessageReporting": { "default": { "logLevel": "none" } },
"tsdocMessageReporting": {
"default": {
"logLevel": "none"
}
},
"extractorMessageReporting": {
"ae-missing-release-tag": { "logLevel": "none" },
"ae-unresolved-link": { "logLevel": "none" }
"ae-missing-release-tag": {
"logLevel": "none"
},
"ae-unresolved-link": {
"logLevel": "none"
}
}
}
}
}
10 changes: 5 additions & 5 deletions sdk/recoveryservices/arm-recoveryservices/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for RecoveryServicesClient.",
"version": "5.0.1",
"version": "5.1.0",
"engines": {
"node": ">=12.0.0"
},
Expand All @@ -28,13 +28,13 @@
"module": "./dist-esm/src/index.js",
"types": "./types/arm-recoveryservices.d.ts",
"devDependencies": {
"@microsoft/api-extractor": "7.18.11",
"@rollup/plugin-commonjs": "^21.0.1",
"@microsoft/api-extractor": "^7.18.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^8.0.0",
"mkdirp": "^1.0.4",
"rollup": "^2.0.0",
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"typescript": "~4.2.0",
"uglify-js": "^3.4.9",
Expand Down Expand Up @@ -99,4 +99,4 @@
},
"sideEffects": false,
"autoPublish": true
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ import { PollOperationState } from '@azure/core-lro';
// @public
export type AuthType = string;

// @public
export type BackupStorageVersion = string;

// @public
export interface CertificateRequest {
properties?: RawCertificateData;
Expand Down Expand Up @@ -155,6 +158,16 @@ export enum KnownAuthType {
Invalid = "Invalid"
}

// @public
export enum KnownBackupStorageVersion {
// (undocumented)
Unassigned = "Unassigned",
// (undocumented)
V1 = "V1",
// (undocumented)
V2 = "V2"
}

// @public
export enum KnownCreatedByType {
// (undocumented)
Expand Down Expand Up @@ -708,6 +721,7 @@ export type VaultPrivateEndpointState = string;

// @public
export interface VaultProperties {
readonly backupStorageVersion?: BackupStorageVersion;
encryption?: VaultPropertiesEncryption;
moveDetails?: VaultPropertiesMoveDetails;
readonly moveState?: ResourceMoveState;
Expand Down
23 changes: 23 additions & 0 deletions sdk/recoveryservices/arm-recoveryservices/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,11 @@ export interface VaultProperties {
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly moveState?: ResourceMoveState;
/**
* Backup storage version
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly backupStorageVersion?: BackupStorageVersion;
}

/** Details for upgrading vault. */
Expand Down Expand Up @@ -892,6 +897,24 @@ export enum KnownResourceMoveState {
*/
export type ResourceMoveState = string;

/** Known values of {@link BackupStorageVersion} that the service accepts. */
export enum KnownBackupStorageVersion {
V1 = "V1",
V2 = "V2",
Unassigned = "Unassigned"
}

/**
* Defines values for BackupStorageVersion. \
* {@link KnownBackupStorageVersion} can be used interchangeably with BackupStorageVersion,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **V1** \
* **V2** \
* **Unassigned**
*/
export type BackupStorageVersion = string;

/** Known values of {@link SkuName} that the service accepts. */
export enum KnownSkuName {
Standard = "Standard",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,13 @@ export const VaultProperties: coreClient.CompositeMapper = {
type: {
name: "String"
}
},
backupStorageVersion: {
serializedName: "backupStorageVersion",
readOnly: true,
type: {
name: "String"
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const subscriptionId: OperationURLParameter = {
export const apiVersion: OperationQueryParameter = {
parameterPath: "apiVersion",
mapper: {
defaultValue: "2021-08-01",
defaultValue: "2022-02-01",
isConstant: true,
serializedName: "api-version",
type: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class RecoveryServicesClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-recoveryservices/5.0.0`;
const packageDetails = `azsdk-js-arm-recoveryservices/5.1.0`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand All @@ -95,7 +95,7 @@ export class RecoveryServicesClient extends coreClient.ServiceClient {

// Assigning values to Constant parameters
this.$host = options.$host || "https://management.azure.com";
this.apiVersion = options.apiVersion || "2021-08-01";
this.apiVersion = options.apiVersion || "2022-02-01";
this.vaultCertificates = new VaultCertificatesImpl(this);
this.registeredIdentities = new RegisteredIdentitiesImpl(this);
this.replicationUsages = new ReplicationUsagesImpl(this);
Expand Down
48 changes: 48 additions & 0 deletions sdk/recoveryservices/arm-recoveryservices/test/sampleTest.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

import {
env,
record,
RecorderEnvironmentSetup,
Recorder
} from "@azure-tools/test-recorder";
import * as assert from "assert";

const recorderEnvSetup: RecorderEnvironmentSetup = {
replaceableVariables: {
AZURE_CLIENT_ID: "azure_client_id",
AZURE_CLIENT_SECRET: "azure_client_secret",
AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
SUBSCRIPTION_ID: "azure_subscription_id"
},
customizationsOnRecordings: [
(recording: any): any =>
recording.replace(
/"access_token":"[^"]*"/g,
`"access_token":"access_token"`
)
],
queryParametersToSkip: []
};

describe("My test", () => {
let recorder: Recorder;

beforeEach(async function() {
recorder = record(this, recorderEnvSetup);
});

afterEach(async function() {
await recorder.stop();
});

it("sample test", async function() {
console.log("Hi, I'm a test!");
});
});
16 changes: 12 additions & 4 deletions sdk/recoveryservices/arm-recoveryservices/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"lib": ["es6", "dom"],
"lib": [
"es6",
"dom"
],
"declaration": true,
"outDir": "./dist-esm",
"importHelpers": true
},
"include": ["./src/**/*.ts", "./test/**/*.ts"],
"exclude": ["node_modules"]
}
"include": [
"./src/**/*.ts",
"./test/**/*.ts"
],
"exclude": [
"node_modules"
]
}
7 changes: 4 additions & 3 deletions sdk/recoveryservices/ci.mgmt.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.

trigger:
branches:
include:
Expand All @@ -10,6 +10,7 @@ trigger:
include:
- sdk/recoveryservices/ci.mgmt.yml
- sdk/recoveryservices/arm-recoveryservices/
- sdk/recoveryservices/arm-recoveryservices
pr:
branches:
include:
Expand All @@ -23,11 +24,11 @@ pr:
include:
- sdk/recoveryservices/ci.mgmt.yml
- sdk/recoveryservices/arm-recoveryservices/

- sdk/recoveryservices/arm-recoveryservices
extends:
template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: recoveryservices
Artifacts:
- name: azure-arm-recoveryservices
safeName: azurearmrecoveryservices
safeName: azurearmrecoveryservices