Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core-rest-pipeline] Add conditional exports (#22804)" #23699

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

jeremymeng
Copy link
Contributor

This reverts commit 02f6ad6.

Packages impacted by this PR

@azure/core-rest-pipeline

Describe the problem that is addressed by this PR

Making core-rest-pipeline ESM with conditional exports broke notification-hubs. Reverting the change while investigating.

@ghost ghost added Azure.Core dev-tool Issues related to the Azure SDK for JS dev-tool eslint plugin labels Nov 3, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremymeng jeremymeng merged commit a6b8d24 into Azure:main Nov 3, 2022
@jeremymeng jeremymeng deleted the core/revert-cond-exports branch November 3, 2022 19:17
mpodwysocki pushed a commit that referenced this pull request Nov 3, 2022
This reverts commit 02f6ad6.


### Packages impacted by this PR
`@azure/core-rest-pipeline`

### Describe the problem that is addressed by this PR
Making core-rest-pipeline ESM with conditional exports broke notification-hubs.  Reverting the change while investigating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core dev-tool Issues related to the Azure SDK for JS dev-tool eslint plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants