Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cognitive Language] Update test-resources.json #24424

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Jan 10, 2023

Packages impacted by this PR

@azure/ai-language-text

Issues associated with this PR

Describe the problem that is addressed by this PR

The Language resource doesn't have access to the storage account. This PR adds a new role assignment for the Language resource in the storage account. The ARM template bit is based on Synapse's.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

N/A

Are there test cases added in this PR? (If not, why?)

N/A

Provide a list of related PRs (if any)

N/A

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@minhanh-phan minhanh-phan merged commit 710885b into main Jan 10, 2023
@minhanh-phan minhanh-phan deleted the cognitivelanguage/update-test-resources branch January 10, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants