Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable smoke tests in release pipeline #24430

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Disable smoke tests in release pipeline #24430

merged 1 commit into from
Jan 11, 2023

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Jan 10, 2023

Per offline discussion, removing this leg until we can replace it with something more robust.

weshaggard
weshaggard approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to file a tracking issue for the replacement? Also does this now mean these aren't running anywhere now?

witemple-msft
witemple-msft approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think that this will only disable it in the release pipeline. We also have a weekly smoke-test pipeline that we could put on hold.

@xirzec xirzec mentioned this pull request Jan 11, 2023
Open
@xirzec
Copy link
Member Author

xirzec commented Jan 11, 2023

Created #24440 to track the replacement.

@witemple-msft - I believe that I have disabled the weekly one in ADO.

@xirzec xirzec merged commit 13791e2 into Azure:main Jan 11, 2023
@xirzec xirzec deleted the removeSmoke branch January 11, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@witemple-msft witemple-msft witemple-msft approved these changes

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@joheredi joheredi Awaiting requested review from joheredi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xirzec @weshaggard @witemple-msft