Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synapse-managed-private-endpoints] Migration to new recorder #24475

Merged

Conversation

minhanh-phan
Copy link
Member

Packages impacted by this PR

synapse-managed-private-endpoints

Issues associated with this PR

#17994

Describe the problem that is addressed by this PR

Migrate to the new recorder

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Synapse label Jan 13, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@minhanh-phan minhanh-phan marked this pull request as ready for review January 13, 2023 18:52
@minhanh-phan minhanh-phan merged commit df98484 into Azure:main Jan 13, 2023
@minhanh-phan minhanh-phan deleted the synapse-endpoint-recorder-migration branch January 13, 2023 21:13
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Aug 24, 2023
Align the casing of LifetimeActionsType with the service. (Azure#24475)

* Align the casing of LifetimeActionsType with the service.

* Add suppressions for EnumUniqueValue

* Fix suppressions YAML

* Move ARM suppressions to right readme.md

---------

Co-authored-by: Heath Stewart <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Sep 13, 2023
Remove redundant "rotate" from Keys API (Azure#25714)

* Remove redundant "rotate" from Keys API

Original goal was to properly document "Rotate" that Key Vault returned and "rotate" that Managed HSM returned (and was originally in the swagger), but that case-insensitively duplicative value caused issues with some code generators.

Reverts parts of Azure#24475

* Remove now-unnecessary exemptions

* Fix description on Notify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants