Bugfix/enable index metrics #26626
Merged
Bugfix/enable index metrics #26626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topshot99
requested review from
kushagraThapar,
kirankumarkolli,
abkolant-MSFT,
simorenoh and
v1k1
as code owners
|
API change check API changes are not detected in this pull request. |
v1k1
reviewed
Sep 4, 2023
| if (results === undefined) { | ||
| break; | ||
| } | ||
| assert.notEqual(indexMetrics, undefined); |
There was a problem hiding this comment.
Can we add checks on structure of indexMetrics. i.e. properties we expect to see in the object.
There was a problem hiding this comment.
@v1k1, this has been already verified in the older PR: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/cosmosdb/cosmos/test/public/indexMetrics.spec.ts .
This PR is for supporting index metrics feature for non-streameable/aggregate queries(we were not supporting index metric header for aggregate queries, this PR fixes it).
v1k1
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
This PR tends to enable index metrics for aggregate queries in node/JS sdk
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists