[ReleasePR @azure/arm-msi] MSI: Use common types. Fix definitions for proper .NET SDK generation.

sdk/msi/arm-msi/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Microsoft
+Copyright (c) 2020 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/msi/arm-msi/README.md

@@ -9,23 +9,24 @@ This package contains an isomorphic SDK for ManagedServiceIdentityClient.
 
 ### How to Install
 
-```
+```bash
 npm install @azure/arm-msi
 ```
 
 ### How to use
 
-#### nodejs - Authentication, client creation and list operations as an example written in TypeScript.
+#### nodejs - Authentication, client creation and getByScope systemAssignedIdentities as an example written in TypeScript.
 
 ##### Install @azure/ms-rest-nodeauth
 
-```
-npm install @azure/ms-rest-nodeauth
+- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
+```bash
+npm install @azure/ms-rest-nodeauth@"^3.0.0"
 ```
 
 ##### Sample code
 
-```ts
+```typescript
 import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
@@ -34,7 +35,8 @@ const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
 
 msRestNodeAuth.interactiveLogin().then((creds) => {
   const client = new ManagedServiceIdentityClient(creds, subscriptionId);
-  client.operations.list().then((result) => {
+  const scope = "testscope";
+  client.systemAssignedIdentities.getByScope(scope).then((result) => {
     console.log("The result is:");
     console.log(result);
   });
@@ -43,11 +45,11 @@ msRestNodeAuth.interactiveLogin().then((creds) => {
 });
 ```
 
-#### browser - Authentication, client creation and list operations as an example written in JavaScript.
+#### browser - Authentication, client creation and getByScope systemAssignedIdentities as an example written in JavaScript.
 
 ##### Install @azure/ms-rest-browserauth
 
-```
+```bash
 npm install @azure/ms-rest-browserauth
 ```
 
@@ -77,7 +79,8 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
           authManager.login();
         }
         const client = new Azure.ArmMsi.ManagedServiceIdentityClient(res.creds, subscriptionId);
-        client.operations.list().then((result) => {
+        const scope = "testscope";
+        client.systemAssignedIdentities.getByScope(scope).then((result) => {
           console.log("The result is:");
           console.log(result);
         }).catch((err) => {
@@ -95,5 +98,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
 
 - [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)
 
-
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Fmsi%2Farm-msi%2FREADME.png)
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/msi/arm-msi/README.png)

sdk/msi/arm-msi/package.json

@@ -4,9 +4,9 @@
   "description": "ManagedServiceIdentityClient Library with typescript type definitions for node.js and browser.",
   "version": "1.1.0",
   "dependencies": {
-    "@azure/ms-rest-azure-js": "^1.1.0",
-    "@azure/ms-rest-js": "^1.1.0",
-    "tslib": "^1.9.3"
+    "@azure/ms-rest-azure-js": "^2.0.1",
+    "@azure/ms-rest-js": "^2.0.4",
+    "tslib": "^1.10.0"
   },
   "keywords": [
     "node",
@@ -20,18 +20,19 @@
   "module": "./esm/managedServiceIdentityClient.js",
   "types": "./esm/managedServiceIdentityClient.d.ts",
   "devDependencies": {
-    "typescript": "^3.1.1",
-    "rollup": "^0.66.2",
-    "rollup-plugin-node-resolve": "^3.4.0",
-    "uglify-js": "^3.4.9"
+    "typescript": "^3.5.3",
+    "rollup": "^1.18.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
+    "rollup-plugin-sourcemaps": "^0.4.2",
+    "uglify-js": "^3.6.0"
   },
-  "homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/sdk/msi/arm-msi",
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/msi/arm-msi",
   "repository": {
     "type": "git",
-    "url": "https://github.com/azure/azure-sdk-for-js.git"
+    "url": "https://github.com/Azure/azure-sdk-for-js.git"
   },
   "bugs": {
-    "url": "https://github.com/azure/azure-sdk-for-js/issues"
+    "url": "https://github.com/Azure/azure-sdk-for-js/issues"
   },
   "files": [
     "dist/**/*.js",
@@ -43,6 +44,7 @@
     "esm/**/*.d.ts",
     "esm/**/*.d.ts.map",
     "src/**/*.ts",
+    "README.md",
     "rollup.config.js",
     "tsconfig.json"
   ],

sdk/msi/arm-msi/rollup.config.js

@@ -1,10 +1,16 @@
+import rollup from "rollup";
 import nodeResolve from "rollup-plugin-node-resolve";
+import sourcemaps from "rollup-plugin-sourcemaps";
+
 /**
- * @type {import('rollup').RollupFileOptions}
+ * @type {rollup.RollupFileOptions}
  */
 const config = {
-  input: './esm/managedServiceIdentityClient.js',
-  external: ["@azure/ms-rest-js", "@azure/ms-rest-azure-js"],
+  input: "./esm/managedServiceIdentityClient.js",
+  external: [
+    "@azure/ms-rest-js",
+    "@azure/ms-rest-azure-js"
+  ],
   output: {
     file: "./dist/arm-msi.js",
     format: "umd",
@@ -16,16 +22,16 @@ const config = {
     },
     banner: `/*
  * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Licensed under the MIT License. See License.txt in the project root for license information.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is
- * regenerated.
+ * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */`
   },
   plugins: [
-    nodeResolve({ module: true })
+    nodeResolve({ mainFields: ['module', 'main'] }),
+    sourcemaps()
   ]
 };
+
 export default config;

sdk/msi/arm-msi/src/managedServiceIdentityClient.ts

@@ -17,6 +17,7 @@ import { ManagedServiceIdentityClientContext } from "./managedServiceIdentityCli
 
 class ManagedServiceIdentityClient extends ManagedServiceIdentityClientContext {
   // Operation groups
+  systemAssignedIdentities: operations.SystemAssignedIdentities;
   operations: operations.Operations;
   userAssignedIdentities: operations.UserAssignedIdentities;
 
@@ -28,6 +29,7 @@ class ManagedServiceIdentityClient extends ManagedServiceIdentityClientContext {
    */
   constructor(credentials: msRest.ServiceClientCredentials, subscriptionId: string, options?: Models.ManagedServiceIdentityClientOptions) {
     super(credentials, subscriptionId, options);
+    this.systemAssignedIdentities = new operations.SystemAssignedIdentities(this);
     this.operations = new operations.Operations(this);
     this.userAssignedIdentities = new operations.UserAssignedIdentities(this);
   }

sdk/msi/arm-msi/src/managedServiceIdentityClientContext.ts

@@ -13,7 +13,7 @@ import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 
 const packageName = "@azure/arm-msi";
-const packageVersion = "0.1.0";
+const packageVersion = "1.1.0";
 
 export class ManagedServiceIdentityClientContext extends msRestAzure.AzureServiceClient {
   credentials: msRest.ServiceClientCredentials;
@@ -44,7 +44,7 @@ export class ManagedServiceIdentityClientContext extends msRestAzure.AzureServic
 
     super(credentials, options);
 
-    this.apiVersion = '2015-08-31-preview';
+    this.apiVersion = '2018-11-30';
     this.acceptLanguage = 'en-US';
     this.longRunningOperationRetryTimeout = 30;
     this.baseUri = options.baseUri || this.baseUri || "https://management.azure.com";