[service-bus] Improve doc strings for create() methods on ServiceBusClient #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
chradek
reviewed
May 7, 2020
chradek
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
…prove cross-advertising of features. :)
ramya-rao-a
reviewed
May 7, 2020
ramya-rao-a
reviewed
May 7, 2020
Also corrected an inaccuracy on the dead letter documentaion. You can't dead letter a dead lettered message!
ramya-rao-a
reviewed
May 9, 2020
ramya-rao-a
reviewed
May 9, 2020
ramya-rao-a
suggested changes
May 11, 2020
There was a problem hiding this comment.
Waiting for #8778 (comment) to be addressed before approving...
Otherwise, rest looks great
ramya-rao-a
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple improvements for the doc strings when describing the receiveMode for create*() methods in ServiceBusClient