DocumentFilterProperties asc property renaming. (#23409)

Azure · Aug 19, 2021 · 8616071 · 8616071
1 parent 878e25f
commit 8616071
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...slation/Azure.AI.Translation.Document/api/Azure.AI.Translation.Document.netstandard2.0.cs b/...slation/Azure.AI.Translation.Document/api/Azure.AI.Translation.Document.netstandard2.0.cs
@@ -2,7 +2,7 @@ namespace Azure.AI.Translation.Document
 {
     public partial class DocumentFilterOrder
     {
-        public DocumentFilterOrder(Azure.AI.Translation.Document.DocumentFilterProperty property, bool asc = true) { }
+        public DocumentFilterOrder(Azure.AI.Translation.Document.DocumentFilterProperty property, bool ascending = true) { }
         public Azure.AI.Translation.Document.DocumentFilterProperty Property { get { throw null; } set { } }
     }
     public enum DocumentFilterProperty

diff --git a/sdk/translation/Azure.AI.Translation.Document/src/DocumentFilterOrder.cs b/sdk/translation/Azure.AI.Translation.Document/src/DocumentFilterOrder.cs
@@ -16,15 +16,15 @@ public class DocumentFilterOrder
         /// <summary>
         /// Initializes an instance of <see cref="DocumentFilterOrder"/>.
         /// </summary>
-        public DocumentFilterOrder(DocumentFilterProperty property, bool asc = true)
+        public DocumentFilterOrder(DocumentFilterProperty property, bool ascending = true)
         {
             Property = property;
-            Asc = asc;
+            Ascending = ascending;
         }
         /// <summary>
         /// Sort results ascendingly if true, or descendingly if false.
         /// </summary>
-        internal bool Asc { get; set; }
+        internal bool Ascending { get; set; }
         /// <summary>
         /// See <see cref="DocumentFilterProperty"/> for list of properties supported.
         /// </summary>
@@ -47,7 +47,7 @@ internal string ToGenerated()
             }
 
             // sorting direction
-            var direction = Asc ? "Asc" : "Desc";
+            var direction = Ascending ? "Asc" : "Desc";
 
             return $"{property} {direction}";
         }

diff --git a/sdk/translation/Azure.AI.Translation.Document/tests/GetAllDocumentsFilterTests.cs b/sdk/translation/Azure.AI.Translation.Document/tests/GetAllDocumentsFilterTests.cs
@@ -93,7 +93,7 @@ public async Task GetDocumentStatusesOrderByCreatedOn()
             // list docs
             var options = new GetDocumentStatusesOptions
             {
-                OrderBy = { new DocumentFilterOrder(property: DocumentFilterProperty.CreatedOn, asc: false) }
+                OrderBy = { new DocumentFilterOrder(property: DocumentFilterProperty.CreatedOn, ascending: false) }
             };
 
             var filterResults = operation.GetDocumentStatuses(options: options);