Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] .NET tests are using a JS resource #17918

Closed
kinelski opened this issue Jan 12, 2021 · 1 comment · Fixed by #25406
Closed

[MetricsAdvisor] .NET tests are using a JS resource #17918

kinelski opened this issue Jan 12, 2021 · 1 comment · Fixed by #25406
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
Backlog

Comments

@kinelski
Copy link
Member

Original discussion: #17894 (comment)

Currently, MA tests use a resource with a js prefix:

azure-sdk-for-net/sdk/metricsadvisor/tests.yml

Line 8 in 9877b91

METRICSADVISOR_ACCOUNT_NAME: "js-metrics-advisor"

The service limits the amount of resources we can create per subscription, so all languages are using the same resource for testing. It has the js prefix because it was only being used by JS originally. We should create and set up a new resource with a better name, but it will take some effort from other languages as well.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. bug This issue requires a change to an existing behavior in the product in order to be resolved. Cognitive - Metrics Advisor labels Jan 12, 2021
@kinelski kinelski added this to the Backlog milestone Jan 12, 2021
@kinelski kinelski mentioned this issue Jan 12, 2021
Merged
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @kinelski. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

@kinelski kinelski removed the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@kinelski kinelski mentioned this issue Nov 18, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Moving to new MA resource kinelski/azure-sdk-for-net
1 participant
@kinelski