Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve architect board feedback for Key Vault #17992

Closed
7 tasks done
heaths opened this issue Jan 15, 2021 · 0 comments · Fixed by #18582
Closed
7 tasks done

Resolve architect board feedback for Key Vault #17992

heaths opened this issue Jan 15, 2021 · 0 comments · Fixed by #18582
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault late-blocker Changes based on review feedback before imminent release.

Comments

@heaths
Copy link
Member

heaths commented Jan 15, 2021

Here are a few things that came up during the archboard review. Note that there is a discussion about whether to expose a LocalCryptographyClient or make it a "mode" of CryptographyClient, but that should only apply to .NET and Java. That is not listed below as prototyping is necessary. But #18575 is tracking that work.

  • Add service version for "7.2". Don't bother with "7.2-preview". It won't be supported anyway, most likely, and "7.2" already is supported by both Key Vault and Managed HSM (rather, Managed HSM ignores it).
  • Rename EncryptOptions to EncryptParameters.
  • Rename DecryptOptions to DecryptParameters.
  • AdditionalAuthenticatedData should be a read-only property (no setters).
  • KeyVaultKeyIdentifier (as well as for secrets and certificates) should not have "parse" methods, but instead take the URI into the constructor/creator. This pattern will, of course, vary from language to language.
  • Make sure all properties on JsonWebKey are settable (came up indirectly, but this should be the case already).
  • (.NET) KeyVault*Identifier structs should implement IEquatable<T>.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jan 15, 2021
@heaths heaths added this to the [2021] February milestone Jan 15, 2021
@heaths heaths self-assigned this Jan 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
@heaths heaths added the late-blocker Changes based on review feedback before imminent release. label May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault late-blocker Changes based on review feedback before imminent release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant